Re: Ping ^ 2: [PATCH] rs6000: Remove unspecs for vec_mrghl[bhw]

[Xionghu Luo <luoxhu@linux.ibm.com>]

Thanks David,

On 2021/10/13 06:51, David Edelsohn wrote:
> Hi, Xionghu
> 
> What's the status of the \M and \m testcase beautification requested
> by Segher?  Did you send an updated patch? Your messages ping the
> version prior to Segher's additional comments.

The pinged link already answered Segher's questions and included a patch
pasted in it.  To follow Segher's preference ;), I just post a v2 patch
here:

https://gcc.gnu.org/pipermail/gcc-patches/2021-October/581497.html

\M and \m are actually not quite necessary to the testcase
gcc.target/powerpc/builtins-1.c since it is built with
"-mdejagnu-cpu=power8 -O0 -mno-fold-gimple -dp", so the testcase also counts
the generated instruction patterns.

> 
> It seems that the changes to the patterns are complete, but there are
> remaining questions about the testcase style and if the instruction
> counts are ideal. I trust that the instruction counts match the
> behavior after the patch, but it seemed that Segher wanted to confirm
> that the counts are the values desired / expected from optimal code
> generation.  The counts are the total for the file, which doesn't
> communicate if the sequences themselves are optimal.

Will rebase and retest after Segher's review of the v2 patch.

-- 
Thanks,
Xionghu