From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C0D5C3858C36 for ; Thu, 3 Nov 2022 19:22:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C0D5C3858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667503336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vh6pgiR/j9HmB2pEjv8HoIH8QaYvcty0SDgJgV25+Ok=; b=hEkfKG6hli4ldkJYZZEdKJ+3MyorkmpOiNHMnsXVOTuO6bCPuju+oyc4Jyjdoe9r/T8JvV YTd9XOggm4EyAHhuYi8L6VPHmlREPutafoU8w7mE1N5bnxHX+VdJUL54TLNYP5WsSPHk/J cf8kssuTZsrgALXGKCftLcaaM6HyYkU= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-353-GG-9MLMENPqIgATPDg0xbQ-1; Thu, 03 Nov 2022 15:22:15 -0400 X-MC-Unique: GG-9MLMENPqIgATPDg0xbQ-1 Received: by mail-qv1-f70.google.com with SMTP id nn2-20020a056214358200b004bb7bc3dfdcso1946125qvb.23 for ; Thu, 03 Nov 2022 12:22:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vh6pgiR/j9HmB2pEjv8HoIH8QaYvcty0SDgJgV25+Ok=; b=NxR0DA68xBKL/nazw7cLWfI/EyO2RTDgQmFaYnvKczZ1nuKFswcdmImslmBG6D/9Km /kueYfmMijBt9kUb9gew3LXJZ88xf6GsOM7jOaj02GYEH2Rz71Ui13HYDkWAOG5r1E7e SrPi95+Nhs3Bgcq0rj0FFYacs85qd6VCHBatibx/8OtwTVytwMXpD9Y0O/8l3NxuvXr8 YTtqiwaREhDmNFDM8XxWMYdIAHX6p9VC+HU/KrR8lH78z5vfXoicpu1qDn8DedHUtROY 2BLlaA5cVlF+QGmKu8Wss7+lDj6AGdtQKLXuehdRDPnwSBYjfuaXc/8UTlX9nP1kRdNV fxaw== X-Gm-Message-State: ACrzQf0osqFwzg2HfyU+DoAuDKQlx0lWSZpJAZv4W1m+iuFDPlTlmmqn pL35eMZTNnT2dsJh75B+0a3ceWInIELVyT75A4wnOpE7eGiWSQXrtlwrKAS0avBTOD1KbTVWQ2+ cdCv8HyIZzilFYYt0VQ== X-Received: by 2002:a05:620a:8d7:b0:6fa:3038:b90c with SMTP id z23-20020a05620a08d700b006fa3038b90cmr16929075qkz.434.1667503334700; Thu, 03 Nov 2022 12:22:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM719CzsvXPF1nGmcHagx4mDMPT/zBrGhaBeJO1JpxptjOAtn80QL4U/P5QjKseXVJhnsjzrVA== X-Received: by 2002:a05:620a:8d7:b0:6fa:3038:b90c with SMTP id z23-20020a05620a08d700b006fa3038b90cmr16929058qkz.434.1667503334377; Thu, 03 Nov 2022 12:22:14 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id fe4-20020a05622a4d4400b00397b1c60780sm1022564qtb.61.2022.11.03.12.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 12:22:13 -0700 (PDT) Message-ID: <8278b3b0-6af7-8c1a-0aad-a093419d7672@redhat.com> Date: Thu, 3 Nov 2022 15:22:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] c++: Disable -Wignored-qualifiers for template args [PR107492] To: Marek Polacek , GCC Patches References: <20221101170156.52672-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20221101170156.52672-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/1/22 13:01, Marek Polacek wrote: > It seems wrong to issue a -Wignored-qualifiers warning for code like: > > static_assert(!is_same_v); > > because there the qualifier matters. Likewise in template > specialization: > > template struct S { }; > template<> struct S { }; > template<> struct S { }; // OK, not a redefinition > > I'm of the mind that we should disable the warning for template > arguments, as in the patch below. Hmm, I'm not sure why we would want to treat template arguments differently from other type-ids. Maybe only warn if funcdecl_p? > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > PR c++/107492 > > gcc/cp/ChangeLog: > > * parser.cc (cp_parser_template_type_arg): Suppress -Wignored-qualifiers > warning. > > gcc/testsuite/ChangeLog: > > * g++.dg/warn/Wignored-qualifiers3.C: New test. > --- > gcc/cp/parser.cc | 4 ++++ > gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C | 12 ++++++++++++ > 2 files changed, 16 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C > > diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc > index e0e3cf3eaf6..54ad4b98ed3 100644 > --- a/gcc/cp/parser.cc > +++ b/gcc/cp/parser.cc > @@ -24334,6 +24334,10 @@ cp_parser_template_type_arg (cp_parser *parser) > const char *saved_message = parser->type_definition_forbidden_message; > parser->type_definition_forbidden_message > = G_("types may not be defined in template arguments"); > + /* It's wrong to issue a -Wignored-qualifiers warning for > + static_assert(!is_same_v); > + because there the qualifier matters. */ > + warning_sentinel w (warn_ignored_qualifiers); > r = cp_parser_type_id_1 (parser, CP_PARSER_FLAGS_NONE, true, false, NULL); > parser->type_definition_forbidden_message = saved_message; > if (cxx_dialect >= cxx14 && !flag_concepts && type_uses_auto (r)) > diff --git a/gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C b/gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C > new file mode 100644 > index 00000000000..5696feaaefe > --- /dev/null > +++ b/gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C > @@ -0,0 +1,12 @@ > +// PR c++/107492 > +// { dg-do compile { target c++14 } } > +// { dg-additional-options "-Wignored-qualifiers" } > + > +template struct S { }; > +template<> struct S { }; > +template<> struct S { }; // { dg-bogus "ignored" } > + > +template constexpr bool is_same_v = false; > +template constexpr bool is_same_v = true; > + > +static_assert( ! is_same_v< void(*)(), const void(*)() >, ""); // { dg-bogus "ignored" } > > base-commit: e7310e24b1c0ca67b1bb507c1330b2bf39e59e32