From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126683 invoked by alias); 4 Dec 2019 21:40:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126651 invoked by uid 89); 4 Dec 2019 21:40:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:683, H*MI:sk:019CCA0, H*f:sk:019CCA0, H*i:sk:019CCA0 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2019 21:40:31 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB4LW6N4098656; Wed, 4 Dec 2019 16:40:29 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wpd12c5kb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Dec 2019 16:40:29 -0500 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id xB4LW8OF098868; Wed, 4 Dec 2019 16:40:29 -0500 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wpd12c5jy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Dec 2019 16:40:29 -0500 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id xB4LdoUq031746; Wed, 4 Dec 2019 21:40:28 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma01dal.us.ibm.com with ESMTP id 2wkg2735cn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Dec 2019 21:40:28 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xB4LeRae33489260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Dec 2019 21:40:27 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9603513605D; Wed, 4 Dec 2019 21:40:27 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0B73136051; Wed, 4 Dec 2019 21:40:26 +0000 (GMT) Received: from [9.160.43.33] (unknown [9.160.43.33]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 4 Dec 2019 21:40:26 +0000 (GMT) Subject: Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins To: Iain Sandoe Cc: Segher Boessenkool , GCC Patches , David Edelsohn References: <6129bc8a-18f3-3c25-22c0-f26e4358c5b3@linux.ibm.com> <20191204191641.GA3152@gate.crashing.org> <4e90e982-6153-0009-c557-f963f41a0427@linux.ibm.com> <019CCA0E-294F-42F4-88F9-C8E52035E5C5@googlemail.com> From: Peter Bergner Message-ID: <82874f29-8ee8-170e-fbdc-dfa646d59968@linux.ibm.com> Date: Wed, 04 Dec 2019 21:40:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <019CCA0E-294F-42F4-88F9-C8E52035E5C5@googlemail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00244.txt.bz2 On 12/4/19 2:47 PM, Iain Sandoe wrote: > Peter Bergner wrote: >> >> Why isn't just testing check_effective_target_dfp enough to disable the >> tests on Darwin, --disable-decimal-float, etc.? > > … It should be a better solution - I will confirm this. Thanks for checking. The nice thing about this solution (if it works for Darwin and the other targets) is that if you eventually add DFP support, then these tests will just automatically start being run for you. Otherwise, you'll have to hunt through the DFP tests looking for a dg-skip-if darwin test. Peter