From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 7D0CD3938C32 for ; Mon, 3 May 2021 11:09:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7D0CD3938C32 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 143B4LwX115546 for ; Mon, 3 May 2021 07:09:10 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 38ad4bcfj6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 03 May 2021 07:09:09 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 143B4a0h116481 for ; Mon, 3 May 2021 07:09:09 -0400 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0b-001b2d01.pphosted.com with ESMTP id 38ad4bcfhr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 May 2021 07:09:09 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 143B8v8V032012; Mon, 3 May 2021 11:09:07 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma02fra.de.ibm.com with ESMTP id 388xm88c8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 May 2021 11:09:07 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 143B94Of34996630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 May 2021 11:09:04 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B0164C046; Mon, 3 May 2021 11:09:04 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C97FC4C04A; Mon, 3 May 2021 11:09:03 +0000 (GMT) Received: from sig-9-145-157-105.de.ibm.com (unknown [9.145.157.105]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 3 May 2021 11:09:03 +0000 (GMT) Message-ID: <828d4e77dd6bec33222cb47f5844bab761ae668b.camel@linux.ibm.com> Subject: Re: [PATCH v2] IBM Z: Handle hard registers in s390_md_asm_adjust() From: Ilya Leoshkevich To: Andreas Krebbel Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek Date: Mon, 03 May 2021 13:09:03 +0200 In-Reply-To: References: <20210428014834.84861-1-iii@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TnI0YCZ84Wqqlsv73GXSdcrgcHXqEN-9 X-Proofpoint-ORIG-GUID: pO7a92dGNoS-tPMwtn1Yt9HTSQFKrwDC Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-03_06:2021-05-03, 2021-05-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105030075 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2021 11:09:12 -0000 On Fri, 2021-04-30 at 08:49 +0200, Andreas Krebbel wrote: > On 4/28/21 3:48 AM, Ilya Leoshkevich wrote: > > Bootstrapped and regtested on s390x-redhat-linux.  Tested with > > valgrind > > too (PR 100278 is now fixed).  Ok for master? > > > > v1: > > https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568771.html > > v1 -> v2: Use the UNSPEC pattern, which is less efficient, but is > > more > >           on the "obviously correct" side than gen_raw_SUBREG(). > > > > > > > > gen_fprx2_to_tf() and gen_tf_to_fprx2() cannot handle hard > > registers, > > since the subregs they create do not pass validation.  Change > > s390_md_asm_adjust() to manually copy between hard VRs and FPRs > > instead > > of using these two functions. > > > > gcc/ChangeLog: > > > >         PR target/100217 > >         * config/s390/s390.c (s390_hard_fp_reg_p): New function. > >         (s390_md_asm_adjust): Handle hard registers. > > > > gcc/testsuite/ChangeLog: > > > >         PR target/100217 > >         * gcc.target/s390/vector/long-double-asm-in-out-hard-fp- > > reg.c: New test. > >         * gcc.target/s390/vector/long-double-asm-inout-hard-fp- > > reg.c: New test. > > Ok. Thanks! > > Andreas Thanks! I forgot to ask: ok for gcc-11 branch?