From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-h2p-567038.sys.comcast.net (resqmta-h2p-567038.sys.comcast.net [IPv6:2001:558:fd02:2446::7]) by sourceware.org (Postfix) with ESMTPS id 954AF3861001 for ; Wed, 24 Apr 2024 02:16:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 954AF3861001 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 954AF3861001 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:558:fd02:2446::7 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713924986; cv=none; b=pHVbE6zEbjSFHUEgusgQUqBLsgNoXAkhjw8qV3qoXz1rmAxE744ElNKqrwqociv5UTKzl/X4wm1vraEkWbHOXHxUkjenRC305oI/vWaM3u2/VOREJlSWfR3IAYZERIFqP2BHBMsUFmRW2ErW6DWQ0tQabBhM2ZDjDa96O53vGT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713924986; c=relaxed/simple; bh=Mg2RW230MMFCM7rPQHU9/D63MCWLAKyLV6HxkQNfL20=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=KZspCNGpqNUErAW/w79bSvWLOu/vEbdV4toOB4Xp0MsY5ttg9nFRmdj5BNlaq0yiD82BrIuh7PgjhcsFA1lYSb36NvNf95G+2zHKR0+7ruOvIOLJzkRZRtoMJKM9KxLXu1M+/G8XmeXRUH0ErkLWcIhDO85mkly93OIen/2/4tE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from resomta-h2p-540626.sys.comcast.net ([96.102.179.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resqmta-h2p-567038.sys.comcast.net with ESMTPS id zRzXrrDTy3eYFzSBJr1yC3; Wed, 24 Apr 2024 02:16:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1713924981; bh=PAx/5ig362M8W9QryLKwm1wxaQGPbHUzMqJDAGHj3ps=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To:Xfinity-Spam-Result; b=gX8rGLpZjvOhKcxPaUz86SBwTaQyx8wVdEiaZgzWl7HEcg/mvGpBr5mGlVO/zbuhS Fe5CNxcHwrlrqyaZ5zob+jsdabQ2iBGPbt5SDodPCd0ssYjWYvYIuf65yzyRdLSLn7 cM8xRUWoXT8dfxdIUeF3j95v0qQX7cCyOgvp3e+0ffCVoZ0y2yvwLopB3nyXcyAqs0 8z4uWLxR//ClKihAIx+DZWnz2kjh9tSS1Wzgdgf6UAqQCwZDBJsg3ZVTi4bgzOx+Fu 6lnShfd7cz+Wv4WitRsXml/YOyms+R0carXCN4fPbmuvwGVnlWmcLMormebyzvp3Mq 0bViTDmR4oSCQ== Received: from smtpclient.apple ([IPv6:2601:644:907e:710:7067:8443:edc8:cfa4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resomta-h2p-540626.sys.comcast.net with ESMTPSA id zSArrYE9MuklhzSAsr5NCw; Wed, 24 Apr 2024 02:15:56 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\)) Subject: Re: [PATCH v2] [testsuite] require sqrt_insn effective target where needed From: Mike Stump In-Reply-To: Date: Tue, 23 Apr 2024 19:15:52 -0700 Cc: GCC Patches , Rainer Orth , David Edelsohn , Segher Boessenkool , Kewen Lin , Hans-Peter Nilsson Content-Transfer-Encoding: 7bit Message-Id: <82D41324-7A16-4A23-BF68-9E881186929A@comcast.net> References: To: Alexandre Oliva X-Mailer: Apple Mail (2.3696.120.41.1.8) X-CMAE-Envelope: MS4xfEZ4aGw9myIzCFACU051DtV6Wzwtb/M3Y4u623OfsaDZQEaJ/QaTCmjxVmmetil29ceudr72GLaCCCELwrjBKIhpyQspJWi4lU28JbD3hW4wk1m92hsB pVwRo3W5SlDeBYHxF0jeOSCuCRhDcBQWxiGPEjjbrTX2cK3J85g+JyeW9+jtzw7n7oFOuT+AprlW/j/KJL+gAhQs3rz1VmRwpo8hL0NBdwcGoprNdBHh22Hu USw+H/Pji0NX6sk4+uU3vDMYZFSOTROMUL8Ou+h1I9zNArVSEtMFaXbov+wg5jAAI5OTPal/qCqpwWMfM+ultFRtahRE8UKM8cyIUKW/4ANHqLl4yNmMBLO6 ukBRJl91D3mJzAEeq2qv7azffmV7pmp+WH/Ta0mcaywapzzcNjgB2EzZrLMwf1CiEMvqk3xcrVY3rP+g5HrCa3utiYoSf7vYj0vAWUkp1VCRXdvbsZc= X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 22, 2024, at 2:56 AM, Alexandre Oliva wrote: > > This patch takes feedback received for 3 earlier patches, and adopts a > simpler approach to skip the still-failing tests, that I believe to be > in line with ppc maintainers' expressed preferences. > https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565939.html > https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566617.html > https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566521.html > Ping?-ish :-) > > > Some tests fail on ppc and ppc64 when testing a compiler [with options > for] for a CPU [emulator] that doesn't support the sqrt insn. > > The gcc.dg/cdce3.c is one in which the expected shrink-wrap > optimization only takes place when the target CPU supports a sqrt > insn. > > The gcc.target/powerpc/pr46728-1[0-4].c tests use -mpowerpc-gpopt and > call sqrt(), which involves the sqrt insn that the target CPU under > test may not support. > > Require a sqrt_insn effective target for all the affected tests. > > Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also testing > with gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? Ok.