gcc/configure: out of date

gcc/configure: out of date

[Martin Liška]

Hello.

I noticed that when I run:
ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf

in gcc subfolder I get the following diff:

diff --git a/gcc/configure b/gcc/configure
index d19059e13cc..ff570f73ef5 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -5352,7 +5352,26 @@ else
    GDC="$ac_cv_prog_GDC"
  fi
  
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether the D compiler works" >&5
+$as_echo_n "checking whether the D compiler works... " >&6; }
+if ${acx_cv_d_compiler_works+:} false; then :
+  $as_echo_n "(cached) " >&6
+else
+  cat >conftest.d <<EOF
+module conftest; int main() { return 0; }
+EOF
+acx_cv_d_compiler_works=no
  if test "x$GDC" != xno; then
+  errors=`(${GDC} -I"$srcdir"/d -c conftest.d) 2>&1 || echo failure`
+  if test x"$errors" = x && test -f conftest.$ac_objext; then
+    acx_cv_d_compiler_works=yes
+  fi
+  rm -f conftest.*
+fi
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $acx_cv_d_compiler_works" >&5
+$as_echo "$acx_cv_d_compiler_works" >&6; }
+if test "x$GDC" != xno && test x$acx_cv_d_compiler_works != xno; then
    have_gdc=yes
  else
    have_gdc=no
@@ -19640,7 +19659,7 @@ else
    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
    lt_status=$lt_dlunknown
    cat > conftest.$ac_ext <<_LT_EOF
-#line 19643 "configure"
+#line 19662 "configure"
  #include "confdefs.h"
  
  #if HAVE_DLFCN_H
@@ -19746,7 +19765,7 @@ else
    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
    lt_status=$lt_dlunknown
    cat > conftest.$ac_ext <<_LT_EOF
-#line 19749 "configure"
+#line 19768 "configure"
  #include "confdefs.h"
  
  #if HAVE_DLFCN_H

Am I correct that somebody forgot to re-generate the file?

Martin

Re: gcc/configure: out of date

[Martin Liška]

On 1/14/22 16:46, Martin Liška wrote:
> Hello.
> 
> I noticed that when I run:
> ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf
> 
> in gcc subfolder I get the following diff:

Have it, started with:


commit 7c6ae994fb587c19ca14aebe18dbc9aca83be609
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Thu Dec 16 23:56:16 2021 +0100

     config: Add check whether D compiler works (PR103528)
     
     As well as checking for the existence of a GDC compiler, also validate
     that it has also been built with libphobos, otherwise warn or fail with
     the message that GDC is required to build d.
     
     config/ChangeLog:
     
             PR d/103528
             * acx.m4 (ACX_PROG_GDC): Add check whether D compiler works.
     
     ChangeLog:
     
             * configure: Regenerate.

I'm going to push the patch I pasted in the previous email.

Martin

Re: gcc/configure: out of date

[Iain Buclaw]

Excerpts from Martin Liška's message of Januar 14, 2022 4:51 pm:
> On 1/14/22 16:46, Martin Liška wrote:
>> Hello.
>> 
>> I noticed that when I run:
>> ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf
>> 
>> in gcc subfolder I get the following diff:
> 
> Have it, started with:
> 

Good spot! Thanks.

Iain.

Re: gcc/configure: out of date

[Martin Sebor]

Martin, I've looked into removing the -Wno-error for this warning
for just a subset of targets.  It seems doable with some hardcoding
in configure.ac but if you're planning to do the cleanup for all of
them I'm wondering if we should even bother.  What do you think?

Martin

On 1/14/22 08:46, Martin Liška wrote:
> Hello.
> 
> I noticed that when I run:
> ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  
> AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf
> 
> in gcc subfolder I get the following diff:
> 
> diff --git a/gcc/configure b/gcc/configure
> index d19059e13cc..ff570f73ef5 100755
> --- a/gcc/configure
> +++ b/gcc/configure
> @@ -5352,7 +5352,26 @@ else
>     GDC="$ac_cv_prog_GDC"
>   fi
> 
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether the D 
> compiler works" >&5
> +$as_echo_n "checking whether the D compiler works... " >&6; }
> +if ${acx_cv_d_compiler_works+:} false; then :
> +  $as_echo_n "(cached) " >&6
> +else
> +  cat >conftest.d <<EOF
> +module conftest; int main() { return 0; }
> +EOF
> +acx_cv_d_compiler_works=no
>   if test "x$GDC" != xno; then
> +  errors=`(${GDC} -I"$srcdir"/d -c conftest.d) 2>&1 || echo failure`
> +  if test x"$errors" = x && test -f conftest.$ac_objext; then
> +    acx_cv_d_compiler_works=yes
> +  fi
> +  rm -f conftest.*
> +fi
> +fi
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: 
> $acx_cv_d_compiler_works" >&5
> +$as_echo "$acx_cv_d_compiler_works" >&6; }
> +if test "x$GDC" != xno && test x$acx_cv_d_compiler_works != xno; then
>     have_gdc=yes
>   else
>     have_gdc=no
> @@ -19640,7 +19659,7 @@ else
>     lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
>     lt_status=$lt_dlunknown
>     cat > conftest.$ac_ext <<_LT_EOF
> -#line 19643 "configure"
> +#line 19662 "configure"
>   #include "confdefs.h"
> 
>   #if HAVE_DLFCN_H
> @@ -19746,7 +19765,7 @@ else
>     lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
>     lt_status=$lt_dlunknown
>     cat > conftest.$ac_ext <<_LT_EOF
> -#line 19749 "configure"
> +#line 19768 "configure"
>   #include "confdefs.h"
> 
>   #if HAVE_DLFCN_H
> 
> Am I correct that somebody forgot to re-generate the file?
> 
> Martin

Enable -Werror=format-diag for bootstrap

[Martin Liška]

On 1/16/22 01:31, Martin Sebor wrote:

Hello.

(I think your message in unrelated to this email thread).

> Martin, I've looked into removing the -Wno-error for this warning
> for just a subset of targets.  It seems doable with some hardcoding
> in configure.ac but if you're planning to do the cleanup for all of
> them I'm wondering if we should even bother.  What do you think?

Yes, I've just installed patches that should address all -Wformat-diag errors
for all targets we have.

Please enable the corresponding -Werror for bootstrap.

Thanks,
Martin

> 
> Martin

Re: Enable -Werror=format-diag for bootstrap

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On 1/18/22 17:28, Martin Liška wrote:
> On 1/16/22 01:31, Martin Sebor wrote:
> 
> Hello.
> 
> (I think your message in unrelated to this email thread).
> 
>> Martin, I've looked into removing the -Wno-error for this warning
>> for just a subset of targets.  It seems doable with some hardcoding
>> in configure.ac but if you're planning to do the cleanup for all of
>> them I'm wondering if we should even bother.  What do you think?
> 
> Yes, I've just installed patches that should address all -Wformat-diag errors
> for all targets we have.
> 
> Please enable the corresponding -Werror for bootstrap.

I've got a patch that enables that. Right now, there should not be any -Wformat-diag
in any target. Thus I'm going to install the following patch.

Martin

> 
> Thanks,
> Martin
> 
>>
>> Martin
> 

[-- Attachment #2: 0001-Enable-Werror-format-diag-during-bootstrap.patch --]
[-- Type: text/x-patch, Size: 2103 bytes --]

From 54c453980fb2b04f6605dc8d50e3472e37a3e629 Mon Sep 17 00:00:00 2001
From: Martin Liska <mliska@suse.cz>
Date: Wed, 19 Jan 2022 11:54:59 +0100
Subject: [PATCH] Enable -Werror=format-diag during bootstrap.

gcc/ChangeLog:

	* configure.ac: Remove -Wno-error=format-diag.
	* configure: Regenerate.
---
 gcc/configure    | 4 ++--
 gcc/configure.ac | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/configure b/gcc/configure
index fd7227078e4..3b228c3d9dc 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -7089,7 +7089,7 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu
 
 loose_warn=
 save_CXXFLAGS="$CXXFLAGS"
-for real_option in -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-error=format-diag $wf_opt; do
+for real_option in -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual $wf_opt; do
   # Do the check with the no- prefix removed since gcc silently
   # accepts any -Wno-* option on purpose
   case $real_option in
@@ -7147,7 +7147,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
 
 c_loose_warn=
 save_CFLAGS="$CFLAGS"
-for real_option in -Wstrict-prototypes -Wmissing-prototypes -Wno-error=format-diag; do
+for real_option in -Wstrict-prototypes -Wmissing-prototypes ; do
   # Do the check with the no- prefix removed since gcc silently
   # accepts any -Wno-* option on purpose
   case $real_option in
diff --git a/gcc/configure.ac b/gcc/configure.ac
index 40cfd38fe56..472d1c8c341 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -573,11 +573,11 @@ AS_IF([test $enable_build_format_warnings = no],
       [wf_opt=-Wno-format],[wf_opt=])
 ACX_PROG_CXX_WARNING_OPTS(
 	m4_quote(m4_do([-W -Wall -Wno-narrowing -Wwrite-strings ],
-		       [-Wcast-qual -Wno-error=format-diag $wf_opt])),
+		       [-Wcast-qual $wf_opt])),
 		       [loose_warn])
 ACX_PROG_CC_WARNING_OPTS(
 	m4_quote(m4_do([-Wstrict-prototypes -Wmissing-prototypes ],
-	 	       [-Wno-error=format-diag])), [c_loose_warn])
+		       [])), [c_loose_warn])
 ACX_PROG_CXX_WARNING_OPTS(
 	m4_quote(m4_do([-Wmissing-format-attribute ],
 		       [-Woverloaded-virtual])), [strict_warn])
-- 
2.34.1