From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Check endianess detection.
Date: Mon, 23 Mar 2020 10:25:32 +0100 [thread overview]
Message-ID: <82f5cda2-97f4-039e-5094-c528b220eb78@suse.cz> (raw)
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
Hi.
As seen in the PR, sparc64 LTO test-suite fails due to missing
definition of __BIG_ENDIAN__ macro. That said, I updated the
endianess detection to use __BYTE_ORDER__.
I tested the detection on x86_64-linux-gnu, ppc64-linux-gnu and
lto.exp testsuite survives on a sparc64-linux machine.
Ready to be installed?
Thanks,
Martin
include/ChangeLog:
2020-03-23 Martin Liska <mliska@suse.cz>
PR lto/94249
* plugin-api.h: Use __BYTE_ORDER__ instead of __BIG_ENDIAN__
which is not defined on sparc64 target.
---
include/plugin-api.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[-- Attachment #2: 0001-Check-endianess-detection.patch --]
[-- Type: text/x-patch, Size: 681 bytes --]
diff --git a/include/plugin-api.h b/include/plugin-api.h
index 673f136ce68..5a45ce773f7 100644
--- a/include/plugin-api.h
+++ b/include/plugin-api.h
@@ -89,16 +89,18 @@ struct ld_plugin_symbol
char *version;
/* This is for compatibility with older ABIs. The older ABI defined
only 'def' field. */
-#ifdef __BIG_ENDIAN__
+#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
char unused;
char section_kind;
char symbol_type;
char def;
-#else
+#elif __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
char def;
char symbol_type;
char section_kind;
char unused;
+#else
+#error "Could not detect architecture endianess"
#endif
int visibility;
uint64_t size;
next reply other threads:[~2020-03-23 9:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 9:25 Martin Liška [this message]
2020-03-23 9:43 ` Jakub Jelinek
2020-03-23 10:00 ` Martin Liška
2020-03-23 10:10 ` Jakub Jelinek
2020-03-23 10:28 ` Martin Liška
2020-03-23 10:35 ` Jakub Jelinek
2020-03-23 12:43 ` Martin Liška
2020-03-23 15:06 ` Martin Liška
2020-03-23 15:39 ` Richard Biener
2020-03-23 16:06 ` H.J. Lu
2020-03-23 17:17 ` Martin Liška
2020-03-23 17:40 ` H.J. Lu
2020-03-24 8:19 ` Martin Liška
2020-03-24 8:31 ` Jakub Jelinek
2020-03-24 8:49 ` Martin Liška
2020-03-24 9:18 ` Jakub Jelinek
2020-03-24 10:32 ` Martin Liška
2020-03-24 10:39 ` Jakub Jelinek
2020-03-31 13:27 ` [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro Maciej W. Rozycki
2020-04-01 5:01 ` Hans-Peter Nilsson
2020-04-01 7:43 ` Martin Liška
2020-04-01 23:57 ` Hans-Peter Nilsson
2020-04-01 7:17 ` Richard Biener
2020-04-01 7:41 ` Martin Liška
2020-04-01 9:55 ` Maciej W. Rozycki
2020-04-01 10:01 ` Martin Liška
2020-04-01 15:59 ` Maciej W. Rozycki
2020-04-01 16:54 ` Martin Liška
2020-04-01 17:28 ` Maciej W. Rozycki
2020-04-01 10:04 ` Maciej W. Rozycki
2020-04-01 10:09 ` Martin Liška
2020-03-23 15:16 ` [PATCH] Check endianess detection Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82f5cda2-97f4-039e-5094-c528b220eb78@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).