From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 0B7023858C2B; Mon, 20 Mar 2023 08:07:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B7023858C2B Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1679299666; bh=6+mqyg7+vwvhlDYScGMFLkxK6NkdepHQaiJaLGsr3xs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=X5QIdl0baDijpqmskh4Ke1yMea/fIRCl6XgPxXPNemmP8202aSnnu8JF9gXCpKIK2 JgpXZoc+UJjbb9geoqQfu6tZWM52fe2aENYkIGStr3CPNyxDvhHSRo1/yklTRB5QyO ND2fws1KxqILzU/8HT21ctha8IEqE1siyWRFWNCQ= Received: from [IPv6:240e:358:11f7:6300:dc73:854d:832e:4] (unknown [IPv6:240e:358:11f7:6300:dc73:854d:832e:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id DFFF26612C; Mon, 20 Mar 2023 04:07:40 -0400 (EDT) Message-ID: <830648d9293be2e7895e0b40ccac9cce16858aa3.camel@xry111.site> Subject: Re: [PATCH] libstdc++: use new built-in trait __is_reference From: Xi Ruoyao To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, Patrick Palka , libstdc++@gcc.gnu.org Date: Mon, 20 Mar 2023 16:07:34 +0800 In-Reply-To: References: <45e80ead7387ef50026922c217a33719bfc66a4a.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-03-20 at 01:03 -0700, Ken Matsui wrote: > Oops, I assumed those were my email... Thank you for your heads up and > your comments! >=20 > > Bad ChangeLog format.=C2=A0 You should have a tab (not 4 or 8 spaces, n= or > > nothing) to indent the ChangeLog content. >=20 > Do you mean like the following? >=20 > ``` > libstdc++-v3/ChangeLog: >=20 > [TAB]* include/std/type_traits (is_reference): Use __is_reference > built-in > trait. > ``` Yep. > > Is there any benefit to use a builtin, instead of the existing > > implementation?=C2=A0 I can see no but maybe I'm stupid. >=20 > My patches are based on the GSoC project "C++: Implement compiler > built-in traits for the standard library traits". These built-in > traits basically make the compilation faster. >=20 > https://gcc.gnu.org/wiki/SummerOfCode Ok, to me making compilation faster is a valid reason. > > The patch fails to apply.=C2=A0 It seems because your mail client inser= ted an > > additional newline before "b/".=C2=A0 Try to use git-send-email or conf= igure > > the mail client properly. >=20 > Let me try to use git-send-email instead. I stupidly don't understand > how to use them, so I was making my patches manually... Or adjust the mail client correctly. You can send the patch to yourself first and see if it's not "mangled" by the mail client when you debug such an issue... But when you finally end up sending 10 patches in a series you'll find git send-email much easier :). --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University