From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 8C4C43858001 for ; Tue, 7 Sep 2021 18:33:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C4C43858001 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 187IJAo4012809; Tue, 7 Sep 2021 18:33:13 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3axd8q0188-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Sep 2021 18:33:13 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 187IU7g2108650; Tue, 7 Sep 2021 18:33:12 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by aserp3030.oracle.com with ESMTP id 3axcpmj4xs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Sep 2021 18:33:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enDS62EfvUf5hIAfHxEXsOvaGFFuuH+ebmZ9fqQGDIy+a3x7M7N3d8DL7r8XwttcExCfS5AxpUyJDHW7/W/GjRzp810birPLMD1rZsvLVCNy5L6NLL6Kit4lgKfnGzZ11E4LhOwZDaSL8Sipe+xk16R5FquHxBsqCkhhtBNkDA6sm5AhEB0hE7GsiW0ZGmEDQX2Pl7eI9zXDkjjJdQ+xILOGbsQsWuTrZcv0YMF7Ip6v9Yl+oPi7sU4+CZDXVcyVdYc42PR9TbTiecT1e2DQyPG2BLKdXmrtJH/5IAH96r3eOXdcVGVApRqaoq/KJeNu6QB0qX+M/CcDvgM0o1CCvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jabXsYT3kWBFWNRtr9id3eQn/UdTxnjGpaZWUMFXe14=; b=RZBd7CihOOI/0i43QXeu4jwT/Orm2g2c8zkzZqTaPku5csGIb1LdDDE4iFr1bv6ekAfy9ohgM2/NlFiBWv6K/BPqsw++GV8O8Mjaa8kBODHhLEcb9+l/nPOPIGO9jwdDGVepSQVaU0papso+R7KrshTGEG531c1Ox7oDZ2p9epVm/+18Mwxr4VB7O9qF/sYPGJSaqwV2cvgRa3jQ+PFfmzDCBqD7cBrfmfCqGRilB9IaO7fnG7s3HFRIzgzJ0oef4YMNtHzVKrmRwz48Aw6WGU9J6Yera1eGC6ZSoAHhAT8WAfVDmYUNXjhJeveyKYFP9pKqbjmpxq5RfMFErqwzog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by CH0PR10MB4908.namprd10.prod.outlook.com (2603:10b6:610:cb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 18:33:10 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::25f8:eaf:a3b9:fe86]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::25f8:eaf:a3b9:fe86%4]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 18:33:10 +0000 From: Qing Zhao To: Richard Biener CC: Richard Sandiford , Nick Alcock via Gcc-patches , kees Cook Subject: Re: [patch][version 8]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc Thread-Topic: [patch][version 8]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc Thread-Index: AQHXlsgrrjav3TK6kE+1EliMGszNb6uW4uyAgAICaQCAABq2AA== Date: Tue, 7 Sep 2021 18:33:10 +0000 Message-ID: <830868A1-E57D-45A9-B48D-B2870B2D22C0@oracle.com> References: <5359AB79-9C10-4C94-8493-420A47468A5D@oracle.com> In-Reply-To: <5359AB79-9C10-4C94-8493-420A47468A5D@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3608.120.23.2.7) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b8c7418-a9f8-47f5-cf8b-08d9722df18d x-ms-traffictypediagnostic: CH0PR10MB4908: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: scuFet+VcGMZ1k73HrSvTnswW47bFVtm1kI4JdtVkdBaApU5yn4M8Unr4RCOUd76qf5XYvgkPZZZFltlvR/cY3xdS/96wLNMeguCs/0rF9wZvfTH35kS7kh8aU4LP2b71me9oTnTWUJ7Y8IMpbLGCKQ7EkdOQPMMUQPzU80/aEsUYETDgIzd32vzpzOFFBjD4zYZLqP8icCPH4/gdUX8NdrCDgBxyUPO9B0S3dW29QNZcPUD/5qKCC2U3noF8JSr8MCUNpbxAdfF3ZFiQbecZvVj8JxzMANgcRuZoEQlB6le/y20Xe/1PtB860InQ5HwJGQVy6BUZThtDuJVYkA+/r1rWH8EaH1YGdz74mOfBM+RQ9OYyP2Ry2x9EUsCRgwFeGiiNm5qmXe2RgNrQ9ZOCjVH2DHOTFTWxfLyz9GL5jjz9/egg/wI3SgJA3gO8BA8Acd0n7pjRj43MvkO5fsdVGuXOaAeGiyfsF51Ag8b+cGzsiFlV3rM+/5tZ3MHQX4pzAbUajS1ukNKyLE2z5IEVYQHDMpR3ZJLAXLK6PKYB4I7tD9m5BV6lW30XH6uZiorqtrCciPXByP1UnOiLm9fcTlzwp7gI6/vDCT70zh2F0q0BKK87DuPz5LphMeEvHAngKsLfk4eBozivde442bo5dLXWHRKXINWoI5DMYvChExWACtvTn6b7GytWORa64+C9Dl1999HhLucbC2RZ2k1CFcgyijJyuTFAAC0vSxZiJnQhI4GkHOEaJYcsCL/7maT x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR10MB4344.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(39860400002)(396003)(346002)(376002)(4326008)(8936002)(5660300002)(8676002)(478600001)(316002)(54906003)(38100700002)(71200400001)(6506007)(38070700005)(53546011)(86362001)(91956017)(76116006)(66946007)(66556008)(4743002)(186003)(122000001)(66446008)(6512007)(44832011)(83380400001)(6486002)(33656002)(36756003)(2906002)(6916009)(2616005)(64756008)(66476007)(45980500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zhpPkTogT3LaSH/TdWskDJFHizZIICl2WynXjo2V5bAhuqmJtCZihoJ6qoK8?= =?us-ascii?Q?00OtPDRYYOnU3FgXUoZMkgdVbhQc0MQ2YVOrPfd1LSbefQ68qCc9IZfg7LO5?= =?us-ascii?Q?WML7/JF2xRtoVDQNPzE/+grJtIajCwqPqgeLouechzSCIpWjllypsdhv1CFO?= =?us-ascii?Q?I6lYG4IJWBX4vCyqWqMKsmlqJ/JerHRbk5eqSboHro/eyqX4o1Y0OhbBIbUr?= =?us-ascii?Q?cYLMwqWbtzaQOiEtZUG21ajf45iPv9XDL4/71UKeXCao0fRGcURxyzxbttLi?= =?us-ascii?Q?p9uJ6HjoLNqeuscTJoBTeVtMRzXdU2kb6KmB7yWMDPKcuJsBrxPbZkKJILdd?= =?us-ascii?Q?EEDeNvQCw4szunJoxz6AuRDXdMUAVav4rG/qQas86b8IBwmFZvPDZksYzLCA?= =?us-ascii?Q?5THODcqmMBZvbab+xbPdHuV66/u/X/UHlRgcx6y13okv2S75DnfSmHDP7Vaw?= =?us-ascii?Q?iUMCyqYAZZGWtRTyrBoQLN2gqZbMifERxkqltp5qHlWZruImbDRY3eOYDuon?= =?us-ascii?Q?fuJgF7QnoWQ9Tc/btNlKZDCCR4Lziy6/dJkeW8XBxlb2JNsxFRekQ+dKyvAx?= =?us-ascii?Q?BDqdRlnsvYnCtZ/KgmigHj9AjleAs8hQaHac2JadZLVk1B3wQYJeDh+wbji3?= =?us-ascii?Q?+++x/pGv+0m0ZLBWEnmhs9CSfOauZqUU2UMet20OWGItOUsPT8jU83ta9iE7?= =?us-ascii?Q?NdtwXBjJB9kNiWK834IXodjN5mrUHNXwONvo6i9qFdZObPcqX18N08StUEhS?= =?us-ascii?Q?aipQy32b3yGBX0yB1oeXuNQIbv70eQZQ2ffTZwUWzDx4Z9PzSJt8pVTMtJGc?= =?us-ascii?Q?xWHZYXhIHABcBZvn79CGQP3//ii1Wa936wu5Ngt+h1TF5vGTFsVrdw44IN/5?= =?us-ascii?Q?AX0/CseojBiYb4A3Fj4D5eq9NzJhflCzgWpa1SjdgLVz1q4mvNJY/+xdllsB?= =?us-ascii?Q?+DWGAriMzyjv+yDRSazY4FOZYRSDWwa8EA7WKV1bj8wh2LgPhc/n+HRr6JuN?= =?us-ascii?Q?j5E1L8cF2f72TJoeK4rwE0uVmnP1bLi52Xqkj807aRnhYc00vN/laIOZiZy7?= =?us-ascii?Q?nUKSFlWeTcAKzNLMrzH7BqQBuM2IFGpxI6sLzZO/g4eB8TcTGDNdWzH/xrVY?= =?us-ascii?Q?iS6Pneb6+IQCD0RvDRbq2dOGQ9Is/sDSDmMZdd7hG6+0RQ1N7uaqnhfaWSZW?= =?us-ascii?Q?j5ZBmO9z0I7fre6m1T5qiaZ5gKQnZriMqCmgE6FknYVKudqxiQbmRteMzit9?= =?us-ascii?Q?P4pS9W9cyHXgf3iVqKhdZGaJULGPfBcoCZvDWimJFpljRrLNfKJ2iPXrQprk?= =?us-ascii?Q?nDkTh+yFtvuoUpbahU9TbFX9O6Iqe337R2MycoqguZw7yRDS5J82/N4UARhV?= =?us-ascii?Q?ocAV/co=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <97F0983CCAEFDA4198B96B65E5897E25@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b8c7418-a9f8-47f5-cf8b-08d9722df18d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 18:33:10.0457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rf2B/t2gb8ASVlXYwIbz8nqVKW9Nq2oAvm15Qa3dB0XdgnjHn1dhTdbN7y/03Fvf1d0nuzqiT8lK4GK05v/w0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4908 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10100 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109070118 X-Proofpoint-GUID: l-jZauqcnGKI93Dr3NFqQNpwYJWrVIIX X-Proofpoint-ORIG-GUID: l-jZauqcnGKI93Dr3NFqQNpwYJWrVIIX X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 18:33:20 -0000 > On Sep 7, 2021, at 11:57 AM, Qing Zhao via Gcc-patches wrote: >=20 > Hi, Richard, >=20 > Thanks a lot for your review. >=20 >> On Sep 6, 2021, at 5:16 AM, Richard Biener wrote: >>=20 >> On Sat, 21 Aug 2021, Qing Zhao wrote: >>=20 >>> Hi, >>>=20 >>> This is the 8th version of the patch for the new security feature for G= CC. >>> I have tested it with bootstrap on both x86 and aarch64, regression tes= ting on both x86 and aarch64. >>> Also tested it with the kernel testing case provided by Kees. >>> Also compile CPU2017 (running is ongoing), without any issue. >>>=20 >>> Please take a look at this patch and let me know any issues. >>=20 >> + /* If this DECL is a VLA, a temporary address variable for it has bee= n >> + created, the replacement for DECL is recorded in DECL_VALUE_EXPR=20 >> (decl), >> + we should use it as the LHS of the call. */ >> + >> + tree lhs_call >> + =3D is_vla ? DECL_VALUE_EXPR (decl) : decl; >> + gimplify_assign (lhs_call, call, seq_p); >>=20 >> you shouldn't need to replace the lhs with DECL_VALUE_EXPR of it >> here, gimplify_assign should take care of that. >=20 > Okay, I see. >=20 > I will change the above sequence simply to the following: >=20 > - /* If this DECL is a VLA, a temporary address variable for it has been > - created, the replacement for DECL is recorded in DECL_VALUE_EXPR (d= ecl), > - we should use it as the LHS of the call. */ > - > - tree lhs_call > - =3D is_vla ? DECL_VALUE_EXPR (decl) : decl; > gimplify_assign (lhs_call, call, seq_p); > } >=20 Changes here should be: - /* If this DECL is a VLA, a temporary address variable for it has been - created, the replacement for DECL is recorded in DECL_VALUE_EXPR (dec= l), - we should use it as the LHS of the call. */ - - tree lhs_call - =3D is_vla ? DECL_VALUE_EXPR (decl) : decl; - gimplify_assign (lhs_call, call, seq_p); + gimplify_assign (decl, call, seq_p); } Qing