public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: Qing Zhao <qing.zhao@oracle.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] middle-end: Skip initialization of opaque type register variables [PR103127]
Date: Wed, 01 Dec 2021 20:07:24 +0100	[thread overview]
Message-ID: <831C6E55-0273-48C7-8BA2-600004381BA6@gmail.com> (raw)
In-Reply-To: <de6fe333-5edc-2bf4-203e-f08fed4ac6a4@linux.ibm.com>

On December 1, 2021 6:42:21 PM GMT+01:00, Peter Bergner <bergner@linux.ibm.com> wrote:
>On 12/1/21 3:01 AM, Richard Biener wrote:
>> Given all this I suggest to exempt OPAQUE_TYPE from is_var_need_auto_init
>> instead of fixing up things at expansion time.
>
>The following fixes the ICE.  The bootstrap/regtesting is still running though.

OK. 

Thanks, 
Richard. 

>Peter
>
>
>diff --git a/gcc/gimplify.c b/gcc/gimplify.c
>index 8624f8221fd..326476f0238 100644
>--- a/gcc/gimplify.c
>+++ b/gcc/gimplify.c
>@@ -1829,6 +1829,7 @@ is_var_need_auto_init (tree decl)
>          || !DECL_HARD_REGISTER (decl))
>       && (flag_auto_var_init > AUTO_INIT_UNINITIALIZED)
>       && (!lookup_attribute ("uninitialized", DECL_ATTRIBUTES (decl)))
>+      && !OPAQUE_TYPE_P (TREE_TYPE (decl))
>       && !is_empty_type (TREE_TYPE (decl)))
>     return true;
>   return false;


  reply	other threads:[~2021-12-01 19:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 21:56 Peter Bergner
2021-11-29 22:56 ` Qing Zhao
2021-11-30  8:37   ` Richard Biener
2021-11-30 15:14     ` Peter Bergner
2021-11-30 17:51       ` Qing Zhao
2021-11-30 18:08         ` Peter Bergner
2021-11-30 19:50           ` Qing Zhao
2021-11-30 20:07             ` Peter Bergner
2021-11-30 20:44               ` Qing Zhao
2021-11-30 22:35                 ` Peter Bergner
2021-12-01  9:01                   ` Richard Biener
2021-12-01 15:06                     ` Qing Zhao
2021-12-01 16:08                       ` Peter Bergner
2021-12-01 17:42                     ` Peter Bergner
2021-12-01 19:07                       ` Richard Biener [this message]
2021-12-01 19:29                         ` Peter Bergner
2021-11-30 17:59     ` Qing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831C6E55-0273-48C7-8BA2-600004381BA6@gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=bergner@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=qing.zhao@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).