From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 26531385840C for ; Thu, 4 Jan 2024 20:31:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26531385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26531385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704400315; cv=none; b=qWiwF7z/SCc0kW9d3daLxZv9ZmyLsrjkorBAxCFjj3f6VvXPIAO4/3SYTnW/oSvVzv7yGkzP/JQKTpaGUImqly1XQv/icH4lqRqVRKaXGA44sxtznmpsyms7YoaN9BVRuMAAxJIFPFPdFGiQoIirgxnlSwU5gxN9Uom8+DlAbkk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704400315; c=relaxed/simple; bh=P3l9DggivGldQ6c27qTP/prTu59yFPDdvl2L7NNttG0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Ze+wlAwQDN72yqSVFEtPB+kmqgnX0hKuo5qLQtxpGX7RqQ19ljHbA0ubf8Ih68luskFaYJwCwjIrdcnQ2iphu80QZTc4s0avoOFFlsmFJgQZWu6AFHiIrC8PNv68t29FB/Wwfkk+EbRVl0MlLDI8l2mYqJIBn+o8AdWIkIN40P8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704400313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffhlbbZC82ClEkLx9Yn4LoL7bb0hPVMxMjh9X6r2Ml0=; b=FQWLl1I9o6JRFBqVRLPG0wSb4JHx0TciOiXrMK97FKaeaiH7nVylxu/uDoSW+5KkPcNI1q HHhHyRIoqBCP3ZgxOt5nZE/q3mHPtZ4rnoOanDLmFlaL8hcB01MW3ptA4exfRgdzge7cTW S4B073ERH3Xef4ZSsXnxJctKdBuKTlQ= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166-TvZhchCjMDSF8Tu1KDbl2Q-1; Thu, 04 Jan 2024 15:31:52 -0500 X-MC-Unique: TvZhchCjMDSF8Tu1KDbl2Q-1 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-6dc2bf709d5so1028734a34.0 for ; Thu, 04 Jan 2024 12:31:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704400312; x=1705005112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ffhlbbZC82ClEkLx9Yn4LoL7bb0hPVMxMjh9X6r2Ml0=; b=RznzXXlT5dOTD3thelme+/Nhq3kn7bW3/4V9w+4c2reGpsMqORGu+zaHNr7d6Mc1dr 74gh22i4vh09ziNyTVBv7qDI2FrhD/gvFF4xpuR109O4j/R/cHHSwHq0fnDZg6NTH7Ot q6j60N5fX64BB/Uj0lA6d+Q5SF2PID2v+sdGOP0BQVWbmCY1F41qPNkd9WoyCJs+pWhH UYG/E1tCsY67SyxGS7TA+ybzsIjuLeck1VL/yreWeBYe+EJW9tkAl2HVzcfRrMz4zx5S HMFDYf0GStCNIRh5SQ5mdyudp3UM7mzJ9a+dLWV/wMZl0hzmrHDQfsM/EyLasiQw5oLN gryg== X-Gm-Message-State: AOJu0YwBXViUCs20hbjK9ioWj8Rvx7mFG+sFNnXojJAxVRyIkPr5qeC9 BTYUou8xy3afKPNCkHSymsT8yD+eIWf0x86mOLsO+BfNidf16D4HrvGBzry+jG3Tvot95dc9iv6 CmHvqz30peL6T/LVrpcFn8LuQxw== X-Received: by 2002:a05:6830:1401:b0:6dc:1cf0:529a with SMTP id v1-20020a056830140100b006dc1cf0529amr1202784otp.8.1704400311955; Thu, 04 Jan 2024 12:31:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9L/kIyiZecJJOJIbr0S2PjSjSBIT0pOc488yrZdKXl5inM3HXtl9vAQVyGONq+6YXMIZBow== X-Received: by 2002:a05:6830:1401:b0:6dc:1cf0:529a with SMTP id v1-20020a056830140100b006dc1cf0529amr1202773otp.8.1704400311694; Thu, 04 Jan 2024 12:31:51 -0800 (PST) Received: from [192.168.1.146] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id l27-20020a05620a211b00b00781c8423ca1sm63927qkl.121.2024.01.04.12.31.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 12:31:51 -0800 (PST) Message-ID: <8323d337-4bc3-4e65-9944-a2d579e66792@redhat.com> Date: Thu, 4 Jan 2024 15:31:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: c++/modules: Emit definitions of ODR-used static members imported from modules [PR112899] To: Nathaniel Shead , gcc-patches@gcc.gnu.org Cc: Nathan Sidwell , Patrick Palka References: <659490fd.170a0220.1ce2e.503a@mx.google.com> From: Jason Merrill In-Reply-To: <659490fd.170a0220.1ce2e.503a@mx.google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/2/24 17:40, Nathaniel Shead wrote: > Static data members marked 'inline' should be emitted in TUs where they > are ODR-used. We need to make sure that statics imported from modules > are correctly added to the 'pending_statics' map so that they get > emitted if needed, otherwise the attached testcase fails to link. Hmm, this seems wrong to me; I'd think that static data members marked inline should be emitted in the module, and not in importers. Jason