Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

[Jeff Law <law@redhat.com>]

On 09/15/2016 08:24 AM, Andrew Burgess wrote:
> * Jakub Jelinek <jakub@redhat.com> [2016-09-14 15:07:56 +0200]:
>
>> On Wed, Sep 14, 2016 at 02:00:48PM +0100, Andrew Burgess wrote:
>>> In an attempt to get this patch merged (as I still think that its
>>> correct) I've investigated, and documented a little more about how I
>>> think things currently work.  I'm sure most people reading this will
>>> already know this, but hopefully, if my understanding is wrong someone
>>> can point it out.
>>
>> I wonder if user_defined_section_attribute instead shouldn't be moved
>> into struct function and be handled as a per-function flag then.
>
> That would certainly solve the problem I'm trying to address.  But I
> wonder, how is that different to looking for a section attribute on
> the function DECL?
I'm not sure it is significantly different.  It seems like it's just an 
implementation detail.  I'd err on the side of putting this into the 
struct function rather than on the DECL node simply to keep the size of 
DECL nodes from increasing.  Even if you can find suitable free flag 
bits, those can likely be better used for other purposes.


I'm still pondering the actual patch.  It's not forgotten.

jeff