From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 1CB1B385840B for ; Thu, 16 Nov 2023 00:03:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CB1B385840B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CB1B385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700093003; cv=none; b=MtzN6970ovt/wAWA3ZmZzQ29OZCnvGwNxz7yQbajOemeOKsqi2NJ44zWI0EyKjZkM9CUHEplh3PGCbmKbmiF4sRsad2UrWXNJHu8Eml9UefzfVCrewy7HHAlFWnXc9TDSH8gujeV+cqO+cBYBr6TusnPyWJfoLBnwturRlS4bFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700093003; c=relaxed/simple; bh=k3iNxielR1KoWYka8c4G7apfs27uHKt4NvZlKFFj5Z8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=stA+5gC9vpJmqsvAcSnJrJm2vpMU0zfGP73UCjXD6AQ71F4Le/WWk/F+YyBIlVhhSOn17mDX4wgcFAYgFVfOpfxuB88cbUbLhYsqKMAl210wcacAEexWX96tOR+bfLvoHAMbSIZ9rpNf4kizlecWHIg7mTzCcW+tBxPx5J8d7OQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1cc131e52f1so10809765ad.0 for ; Wed, 15 Nov 2023 16:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1700092994; x=1700697794; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=+8iDkM7Un+xDdgneBQFGWXFqytNH283buU8ozjtFufs=; b=HeafUs2o3Zlpf3smv088XOFlwiEoxv0ZDTdlSPuPDLZSTJBci6Q0MKkVXNyeAg5A5Y 8d0xea2iBK++6wvTOB0PXHBkNM0fyEiXBbwgaT0x8zzzF9+czBrqmjO9yYvfYj4amTmq eQZOkE5HhbDdP3zpK7JrvU01EU5GLkYgIQ+czGTrm/QciKug9eMQIwcKmM5Ei6JBeiLC U5BwaDnObHMSx3wgS1u8jlhpbCSjZ7Mk4R3j+U1hgbau3lOVCwn7XXQvLbuSjSc/1NUE egB1yNbHiADLINXRTsoPOc6pPDcIGzkuRCiKzglyMNgBG1LM0aSllavKMsNfZkS4UHyz Fi4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700092994; x=1700697794; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+8iDkM7Un+xDdgneBQFGWXFqytNH283buU8ozjtFufs=; b=sjZRhfJ/UTDrgLYZVr2NRBhhHUadwvC9rCxKYyUZ7OM94DuCL1Xt+hKlIGP55xagaF +b2zCOix7Df87U7Um4krCmU7mjLx9Vcf8vSWdnA/gf+VtPTHcLB5864j0twUVoQh2JnF bDgGCaLbHX3yDIkyxfK2RKijq9+pNRcTk0HjHxFlBaWSPndO0uZnnQVl+2U+nxajkcs1 1KEqua8haWJAWhDvpU3avMtEPXkEYoqKFe5YhOXSj+KSDGjhFxUNrdmN1vSevOB3e1M8 hWeDztdR4z0N1Tj9QZfFwjQeqQYDbdbP7ihlExNfAU1GIOd6+WjWlQSkidrAmUvFgJNg vywg== X-Gm-Message-State: AOJu0Yzx6ARCrB/qUnOgeuP84rckAcGE3AmauLF1P2hccGp8HK3qN2Xx PcQzQJgYXY+6wfakVSYEU5o5oJoJ8nTttpgwT2qamQ== X-Google-Smtp-Source: AGHT+IF1JbqPYLPnHvKh2NV84QRAuSTsCfT3uCQSE2WAL/fk4aGFnvUHrjgCBemoxCz3ZltRo3PYlg== X-Received: by 2002:a17:902:e547:b0:1cc:5c49:6af8 with SMTP id n7-20020a170902e54700b001cc5c496af8mr102913plf.25.1700092994431; Wed, 15 Nov 2023 16:03:14 -0800 (PST) Received: from [10.0.17.156] ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id bc5-20020a170902930500b001bba7aab822sm7929820plb.5.2023.11.15.16.03.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Nov 2023 16:03:13 -0800 (PST) Message-ID: <83365982-71b9-46ae-8253-457841caaf99@rivosinc.com> Date: Wed, 15 Nov 2023 16:03:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Patrick O'Neill Subject: [PING] [PATCH] gfortran: Rely on dg-do-what-default to avoid running pr85853.f90, pr107254.f90 and vect-alias-check-1.F90 on non-vector targets To: gcc-patches@gcc.gnu.org Cc: fortran@gcc.gnu.org, Jeff Law , gnu-toolchain References: <20231102190911.66763-1-patrick@rivosinc.com> Content-Language: en-US In-Reply-To: <20231102190911.66763-1-patrick@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. Testsuite fixup similar to: https://inbox.sourceware.org/gcc-patches/974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com/T/#t https://inbox.sourceware.org/gcc-patches/7e78cd70-70c9-41b1-8a98-6977a103429e@rivosinc.com/T/#t Patrick On Thu, Nov 2, 2023 at 12:09 PM Patrick O'Neill wrote: > > Testcases in gfortran.dg/vect/vect.exp rely on > check_vect_support_and_set_flags to set dg-do-what-default and avoid > running vector tests on non-vector targets. The three testcases in this > patch overwrite the default with dg-do run which causes issues > for non-vector targets. > > Removing the dg-do run directive resolves this issue for non-vector > targets (while still running the tests on vector targets). > > gcc/testsuite/ChangeLog: > > * gfortran.dg/vect/pr107254.f90: Remove dg-do run directive. > * gfortran.dg/vect/pr85853.f90: Ditto. > * gfortran.dg/vect/vect-alias-check-1.F90: Ditto. > > Signed-off-by: Patrick O'Neill > --- > Tested using rv64gc & rv64gcv to make sure the testcases compile/run > as expected. > > These files haven't been changed in a long time so I'm not sure why (or > if) this hasn't been run into by other people before. > --- > gcc/testsuite/gfortran.dg/vect/pr107254.f90 | 2 -- > gcc/testsuite/gfortran.dg/vect/pr85853.f90 | 1 - > gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 | 1 - > 3 files changed, 4 deletions(-) > > diff --git a/gcc/testsuite/gfortran.dg/vect/pr107254.f90 b/gcc/testsuite/gfortran.dg/vect/pr107254.f90 > index 85bcb5f3fa2..adce6bedc30 100644 > --- a/gcc/testsuite/gfortran.dg/vect/pr107254.f90 > +++ b/gcc/testsuite/gfortran.dg/vect/pr107254.f90 > @@ -1,5 +1,3 @@ > -! { dg-do run } > - > subroutine dlartg( f, g, s, r ) > implicit none > double precision :: f, g, r, s > diff --git a/gcc/testsuite/gfortran.dg/vect/pr85853.f90 b/gcc/testsuite/gfortran.dg/vect/pr85853.f90 > index 68f4a004324..4c0e3b81a09 100644 > --- a/gcc/testsuite/gfortran.dg/vect/pr85853.f90 > +++ b/gcc/testsuite/gfortran.dg/vect/pr85853.f90 > @@ -1,5 +1,4 @@ > ! Taken from execute/where_2.f90, but with special flags. > -! { dg-do run } > ! { dg-additional-options "-fno-tree-loop-vectorize" } > > ! Program to test the WHERE constructs > diff --git a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 > index 3014ff9f3b6..85ae9b151e3 100644 > --- a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 > +++ b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 > @@ -1,4 +1,3 @@ > -! { dg-do run } > ! { dg-additional-options "-fno-inline" } > > #define N 200 > -- > 2.34.1 >