From: Jeff Law <jeffreyalaw@gmail.com>
To: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
rguenther <rguenther@suse.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"richard.sandiford" <richard.sandiford@arm.com>
Subject: Re: [PATCH V6] VECT: Add SELECT_VL support
Date: Fri, 9 Jun 2023 08:42:00 -0600 [thread overview]
Message-ID: <83410b43-1d61-f2e7-2bff-8c2fef34af5a@gmail.com> (raw)
In-Reply-To: <026C98745E7F4ACA+202306091932227826494@rivai.ai>
On 6/9/23 05:32, juzhe.zhong@rivai.ai wrote:
> Thanks a lot Richi.
>
> Even though last time Richard asked me no need to wait for 2nd ACK,
> I am still want to wait for Richard final approval since I am not sure this patch is ok for him.
If Richard had asked you to wait for Richi and you've done updates based
on Richi's feedback, then it becomes a judgment call -- if the changes
are significant, then we might want Richard to take another look. If
the changes are minor, then getting another ACK isn't necessary.
It's not always clear what the best path forward ought to be and in
cases where it isn't clear, a bit of caution is appreciated.
So to give some clear guidance. Based on my understanding both Richard
and Richi are basically on board with what you've implemented. So how
about this, if Richard hasn't chimed in by the start of your day on
Tuesday, go ahead with the patch. That gives Richard the rest of today
and his Monday if there's something he wants to comment on.
jeff
next prev parent reply other threads:[~2023-06-09 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:39 juzhe.zhong
2023-06-09 9:20 ` juzhe.zhong
2023-06-09 11:02 ` Richard Biener
2023-06-09 11:16 ` juzhe.zhong
2023-06-09 17:44 ` Richard Sandiford
2023-06-09 23:54 ` Li, Pan2
2023-06-09 11:32 ` juzhe.zhong
2023-06-09 14:42 ` Jeff Law [this message]
2023-06-09 14:43 ` 钟居哲
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83410b43-1d61-f2e7-2bff-8c2fef34af5a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).