From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by sourceware.org (Postfix) with ESMTPS id 251CA3858D1E for ; Tue, 11 Jul 2023 22:28:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 251CA3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-56661fe27cbso4331606eaf.3 for ; Tue, 11 Jul 2023 15:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689114529; x=1691706529; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mZhqpECPVuCSIy/cIb8BLgDwy83f2mM3RJXJRG9rt98=; b=VSf+YP7gEVLE0we+Q1xxWgQiSYw0oZ2wHYjs1Zgdm/kS6czPo5I+smpqZyJLFrV+Wg l7hx7VEM31H8y+pXN81hNZbGJGCkesWJUu46d+cG7bpl2MNuF6Tr7yt1DL50n1OZ34R/ j2BuV7SpI3BnwRpq19Biz558zOcTaPUO9fvn+ImZ7r/C3Ojj8C0lFKPJZoy6LfoYjP8i y0ov3i0K4tieWWwdYhwm1sC1YBs4H6mGdpGLQKsSRf3sJNp3E9sLsC5ErAUsuuzhjErl Zrpvqdo3jAWuFPeviIPs7m1jSZg1i+6lzcnE3tnPK6T+rqMjhSk4Bi6qzP7cr9pIFLgI AEDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689114529; x=1691706529; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZhqpECPVuCSIy/cIb8BLgDwy83f2mM3RJXJRG9rt98=; b=d1Hwyj9ajVXEj9Ci2JC3uoiw/jty7uKjpWUw48wQmXc6NDxfWOTO07qgR89uD1qMTB MBiKZrmvGtI3TAkk7T1TVFofR5Y7vCuQU7HRDJiin8wcBy65bEiMhMe3F5pHeg+FvkL0 EdGbYbCh04hvn8oV4xSZQCPUZknIXc2DFCkXGiCHsSyGLmRrlEta/1vpAUbEIDiNxz9m HAc5ka1MM9veUiBVankfCXlE2+K4kDMBtyYeydjLtBB+HJyBEvp1rqgTYORr6UqRN9eH 77Y8RuU6kqoAZpsGJs3s/4eKmEal9HjmYlIPXq3ZPSjuKkEG05RLYFt5GM5hrk9MTfLU /NPA== X-Gm-Message-State: ABy/qLYKTVYTXpjPyuvGtOK1F+Ls8B+Iv1VHTfGyE16woP6anBiXL620 H7hIuWLjzbNMvP3aODzGZPU= X-Google-Smtp-Source: APBJJlEcfV5bIvSLKLAkpERDrrGrE3dxjA+102DU3UkYYIcKN3Q7DIq+N+G43q1/vSPBVpSroWAlrg== X-Received: by 2002:a05:6808:f0e:b0:3a3:c64f:3446 with SMTP id m14-20020a0568080f0e00b003a3c64f3446mr18275512oiw.39.1689114529087; Tue, 11 Jul 2023 15:28:49 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id a2-20020a62bd02000000b00679a4b56e41sm2203889pff.43.2023.07.11.15.28.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 15:28:48 -0700 (PDT) Message-ID: <835f21dd-4655-fb39-6d4a-f5d954a61b94@gmail.com> Date: Tue, 11 Jul 2023 16:28:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610] Content-Language: en-US To: "Andre Vieira (lists)" , "gcc-patches@gcc.gnu.org" Cc: "jakub@redhat.com" , Andrew Pinski References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: > Hi, > > This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H > list, as insn-opinit.h is now required by internal-fn.h. This will lead > to insn-opinit.h, among the other OPTABS_H header files, being installed > in the plugin directory. > > Bootstrapped aarch64-unknown-linux-gnu. > > @Jakub: could you check to see if it also addresses PR 110284? > > > gcc/ChangeLog: > >         PR 110610 >         * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h and insn-codes.h and neither of those #include other headers do they? Jeff