Re: [PATCH v3, Fortran] TS 29113 testsuite

[Tobias Burnus <tobias@codesourcery.com>]

Hi,

On 03.09.21 09:46, Christophe Lyon wrote:
> I'm not quite sure I understand the expected status of this patch: are
> all the "expected" failures tagged as XFAIL?
I think that's the idea.
> If yes, then there's a problem because I see lots of unresolved on
> aarch64/arm
>
> XFAIL: gfortran.dg/c-interop/cf-descriptor-5.f90   -O0  pr92482 (test
> for bogus messages, line 10)
> PASS: gfortran.dg/c-interop/cf-descriptor-5.f90   -O0  (test for
> excess errors)
> UNRESOLVED: gfortran.dg/c-interop/cf-descriptor-5.f90   -O0
>  compilation failed to produce executable

I think that's the usual result for 'dg-do run' tests if the compilation
failed (be it due to errors or due to effective-target-*).

* * *

If I read https://gcc.gnu.org/onlinedocs/gcc/Floating-Types.html
correctly, we should use _Float128 for the following errors

"The _Float128 type is supported on all systems where __float128 is
supported or where long double has the IEEE binary128 format."

Applies to:

> For
> typecodes-array-float128.f90
> FAIL: gfortran.dg/c-interop/typecodes-array-float128.f90   -O0  (test
> for excess errors)
> Excess errors:
> /gcc/testsuite/gfortran.dg/c-interop/typecodes-array-float128-c.c:35:32:
> error: '__float128' undeclared (first use in this function); did you
> mean '_Float128'?
> typecodes-sanity.f90
> FAIL: gfortran.dg/c-interop/typecodes-sanity.f90   -O0  (test for
> excess errors)
> Excess errors:
> /gcc/testsuite/gfortran.dg/c-interop/typecodes-sanity-c.c:41:13:
> error: '__float128' undeclared here (not in a function); did you mean
> '_Float128'?
> typecodes-scalar-float128.f90
> FAIL: gfortran.dg/c-interop/typecodes-scalar-float128.f90   -O0  (test
> for excess errors)
> Excess errors:
> /gcc/testsuite/gfortran.dg/c-interop/typecodes-scalar-float128-c.c:34:32:
> error: '__float128' undeclared (first use in this function); did you
> mean '_Float128'?
* * *
> PR100914.f90
> FAIL: gfortran.dg/PR100914.f90   -O0  (test for excess errors)
> Excess errors:
> /gcc/testsuite/gfortran.dg/PR100914.c:8:10: fatal error: quadmath.h:
> No such file or directory

  * * *

On a normal x86-64 system, I get XPASS for:

gfortran.dg/PR100914.f90

gfortran.dg/c-interop/typecodes-array-float128.f90

The ! { dg-do run { xfail { { x86_64*-*-* i?86*-*-* } && longdouble128 } } }
does not help as it just checks whether 'sizeof(long double)==16',
which seemingly passes also on x86-64 with 80bit long double.

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955