From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by sourceware.org (Postfix) with ESMTPS id B270C385480A for ; Fri, 11 Dec 2020 12:51:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B270C385480A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nathanmsidwell@gmail.com Received: by mail-qt1-x844.google.com with SMTP id f14so6244999qto.12 for ; Fri, 11 Dec 2020 04:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wnd50l2HvDUEzYurO02fjaCUL1zFdjF5+ijWnz6zrKU=; b=sHleNf5f93DvtokR2SKsUJ6U3TI46wpkqbupfeBRVlraPEyV9WedCzVycoBABJw2go 0e+pSu11Frocj4qvGJrRUfesSWtAkPp9GNbUi5fec2G7jSGJJu3TSCHmGsizxSVsUtK+ m1T0yr7njpQbOBJW6u71Xh5U7K20raL6Lx8GMihzVoB7ZGb/eKUZ/7kb6s5XjkLfuU03 uvtoozMBimOH51pG1CvmME3+buRvrMntonraIQdb7i7f98RwKOL1nxTJaG53f8J8QX30 mtCD1ZjK/xQQILqoSxiGm5ANj00kkqx6tcmm841CgjMgwZdNkgLsQkNTaR4gXu8byLoZ dozA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wnd50l2HvDUEzYurO02fjaCUL1zFdjF5+ijWnz6zrKU=; b=igZx6PcTrjB1GM1k54cp73nXyizbN2Wn/asZ2finv/dRHFeDLU8Y8NlSHmYBHnNikD hd766ZOJRVOu+m9NN8dnrnjeEfN+zCpNwAPCnYhL2VEh/KOjW2IBESZKnAXnJCd+74gz jKhXBjvp8SzNhQyD/buONXD2DbZGUqQ14NsoV0br/tFwUnN8zwgHMFymcb1o1xwII0wF yo8G5W0cJ7oU0SsihBRu8OAOrfTkKk10cm3dwmG2KhtLj6+JAlxJmH1FP/uWwTaxIQTm EurUk3I+j/Wn3B73qtbKT2X6XMaZoEdqD07wTkdSyWZjTG0061tIZV76UOPMLow2wSYF Z1JQ== X-Gm-Message-State: AOAM5330xvYD/f8Coz8+bN7LzMN2xrpfpx+JfCkrxtEdlOSmE+/FeNxB 07v0io+1MfFf6GBAlwBhnOs= X-Google-Smtp-Source: ABdhPJxbAa22Wq1H6Sm3OqrOjd5+k5Wzbm5Jla/nOxhR0i4aNj9pDRwxX4TQMsZ2TcCtI8G8vq0kfA== X-Received: by 2002:ac8:71c6:: with SMTP id i6mr15087080qtp.209.1607691113750; Fri, 11 Dec 2020 04:51:53 -0800 (PST) Received: from ?IPv6:2620:10d:c0a8:1102:7d2d:1a8a:7a22:aa55? ([2620:10d:c091:480::1:e048]) by smtp.googlemail.com with ESMTPSA id y15sm6492480qto.51.2020.12.11.04.51.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Dec 2020 04:51:44 -0800 (PST) Sender: Nathan Sidwell Subject: Re: [PATCH] aix: Fixinclude updates [PR98208] To: Ilya Leoshkevich , gcc-patches@gcc.gnu.org References: <20201211005935.709687-1-iii@linux.ibm.com> From: Nathan Sidwell Message-ID: <836afc8a-ef00-b93e-50ce-b3342e000720@acm.org> Date: Fri, 11 Dec 2020 07:51:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20201211005935.709687-1-iii@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2020 12:51:55 -0000 On 12/10/20 7:59 PM, Ilya Leoshkevich wrote: > Tested on gcc121 (x86_64 CentOS Linux 7). Ok for master? > > > > After 92648faa1cb2 ("aix: Fixinclude") make check-fixincludes began to > fail (at least on gcc121 machine). Fix by updating fixincludes/tests > and rerunning genfixes. > diff --git a/fixincludes/tests/base/sys/types.h b/fixincludes/tests/base/sys/types.h > index 683b5e93ecd..a318f9b713b 100644 > --- a/fixincludes/tests/base/sys/types.h > +++ b/fixincludes/tests/base/sys/types.h > @@ -9,6 +9,11 @@ > > > > +#if defined( AIX_PHYSADR_T_CHECK ) > +typedef struct __physadr_s { > +#endif /* AIX_PHYSADR_T_CHECK */ > + I'm pretty sure this is wrong. I think the test_text in inclhack.def should be a pre-fixed string that the testsuite presumably checks is converted. -- Nathan Sidwell