From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by sourceware.org (Postfix) with ESMTPS id A23A93858D1E for ; Tue, 18 Apr 2023 18:10:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A23A93858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-54f6a796bd0so354313697b3.12 for ; Tue, 18 Apr 2023 11:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1681841430; x=1684433430; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/yf6sG1NepK3YO3UTtPKea5tGCou+ApsVStoGyV3mSU=; b=gOYzXxE/hFgiYZ/Gd7GEXNSXUE4JvSd99SZx4l4jBgzQdM/rZCHhcMW0UQSICUs2l9 TWGHtsLzYEIYeVI6W9XZK9kxpEuJDAnf+lS29W7Gpdg0AJsewWybPgn6C+g2R9ALMURs ZxxeN16hIMr0LDKWP1Modks4zEhDlafx5IOxG2QPzk+nmQMAmOEM57hi/KE95MFrdg2h Zbs87VAWlzq8siT/dyg6XlT0w3kGycUKFdUP6v9zGz5B63Ml5PMhIklWcCkVprA1Hmwc SZSBrL9mH0NqA25Ocg5K3O3gPnZknBHi3RKwjZJa54fSu2ppTUafHOvlWubrrDLOfqI/ 6Zow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681841430; x=1684433430; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/yf6sG1NepK3YO3UTtPKea5tGCou+ApsVStoGyV3mSU=; b=POnyd7O/U/U3N1Wm6Cq4xM0io5vzeAoZ8gdVh/W2UcihIZ9iaPC+Aq0bMzR7rqIiIa S6DchNi5yyJQNHUGgFrcGf6ZWFXUJiWfp9plk3uq4NTH9Xw8+pVz9RiHb5ly4qm0JVdZ T7Y0/ThXe4vi9gFlZIFXaC3AYR0XGp7NpQNbBtTC0cgSiFSWH29NrgMGku9u+rHhZyat /iJoZR8dCz83D6AnnLDxsXtOjm2IJe3fr8D0vIw20dyUcJYgeYn4bxyX+uqdlfauFzzj EoakTDg7ggxQ9GJI+swpKdQjJdLE4P/hVMwQADTehmUUymcj+178xnAzE99Hr0blhIj9 xS2w== X-Gm-Message-State: AAQBX9dwWA/1h27HU0vk7tZy43LL2+kdIz7NcQzCjFrpDSZy9aCZxR6O Y9Jdzy1cN4Ubbi9jOQGAVgBahA== X-Google-Smtp-Source: AKy350Zbx8wSMzDiELSoZ4+XwyH7qTUdJtjjQXF/ey0rUaMpqL+l/ASfGtxEaw13PogM0+Y+Lroofg== X-Received: by 2002:a81:48cc:0:b0:552:f3d5:c156 with SMTP id v195-20020a8148cc000000b00552f3d5c156mr712773ywa.13.1681841430018; Tue, 18 Apr 2023 11:10:30 -0700 (PDT) Received: from [192.168.86.117] ([136.57.172.92]) by smtp.gmail.com with ESMTPSA id cs2-20020a05690c0ec200b00545a08184a7sm4000550ywb.55.2023.04.18.11.10.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 11:10:29 -0700 (PDT) Message-ID: <837514e1-b33c-7a80-ed98-971db2e3b027@rivosinc.com> Date: Tue, 18 Apr 2023 14:10:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 09/10] This patch adds a guard for VNx1 vectors that are present in ports like riscv. Content-Language: en-US To: Kito Cheng Cc: gcc-patches@gcc.gnu.org References: <20230417183701.2249183-1-collison@rivosinc.com> <20230417183701.2249183-10-collison@rivosinc.com> From: Michael Collison In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks Kito I will look into this. On 4/18/23 10:26, Kito Cheng wrote: > I would prefer drop this patch from this patch series since I believe > https://patchwork.ozlabs.org/project/gcc/patch/20230414014518.15458-1-juzhe.zhong@rivai.ai/ > is the right fix for this issue. > > On Tue, Apr 18, 2023 at 2:40 AM Michael Collison wrote: >> From: Kevin Lee >> >> Kevin Lee >> gcc/ChangeLog: >> >> * tree-vect-data-refs.cc (vect_grouped_store_supported): Add new >> condition >> --- >> gcc/tree-vect-data-refs.cc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc >> index 8daf7bd7dd3..df393ba723d 100644 >> --- a/gcc/tree-vect-data-refs.cc >> +++ b/gcc/tree-vect-data-refs.cc >> @@ -5399,6 +5399,8 @@ vect_grouped_store_supported (tree vectype, unsigned HOST_WIDE_INT count) >> poly_uint64 nelt = GET_MODE_NUNITS (mode); >> >> /* The encoding has 2 interleaved stepped patterns. */ >> + if(!multiple_p (nelt, 2)) >> + return false; >> vec_perm_builder sel (nelt, 2, 3); >> sel.quick_grow (6); >> for (i = 0; i < 3; i++) >> -- >> 2.34.1 >>