From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id C9B7E3858D1E for ; Wed, 14 Jun 2023 10:00:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9B7E3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.00,242,1681200000"; d="txt'?scan'208";a="9800496" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 14 Jun 2023 02:00:51 -0800 IronPort-SDR: lTNnK1dtrKcuFTGiIsdEQYxUVE9dExGZtRFgOqKKbht1coAZ5HMgg+Ch9kB61Syem7rKlNCPIL NAFOMsS5czLLfetW7QenKkAaH+uU/MxsGMbAXxIEKECEFU9JWvYzrX3maFyk70syFRzfPLaFt7 PBSz5XtaGaQOI7hcgMuXtZVO/f6BEtKNq2XxZzsX/G9f5LdmcZu8fobl7l58oQ3B8dWQVR3dbA 29m9oTFrauODBfjgtrJPYO+Cf50m5mQa0fVWHhZ4GQbM1y4apTmP3WcU9U6cMwjzJhCyZ5E3T0 J40= Content-Type: multipart/mixed; boundary="------------aNJvh57xhucl9JPTa4Nedmga" Message-ID: <837af8e8-3107-8ac3-ad77-aa53509ad6d0@codesourcery.com> Date: Wed, 14 Jun 2023 12:00:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [committed] OpenMP: Cleanups related to the 'present' modifier Content-Language: en-US To: Thomas Schwinge , CC: Jakub Jelinek References: <6eb5d0dd-da2a-6d8e-eaa2-d14bf708cf36@codesourcery.com> <049a4654-2596-1913-20fc-1aeea48eb3ec@codesourcery.com> <64017201-8206-fd22-70e4-897c858ae049@codesourcery.com> <87jzw6305o.fsf@euler.schwinge.homeip.net> From: Tobias Burnus In-Reply-To: <87jzw6305o.fsf@euler.schwinge.homeip.net> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------aNJvh57xhucl9JPTa4Nedmga Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 14.06.23 10:42, Thomas Schwinge wrote: > Couldn't/shouldn't we now get rid of this 'GOMP_MAP_FLAG_PRESENT'... ... >> #define GOMP_MAP_PRESENT_P(X) \ >> - (((X) & GOMP_MAP_FLAG_PRESENT) =3D=3D GOMP_MAP_FLAG_PRESENT) >> + (((X) & GOMP_MAP_FLAG_PRESENT) =3D=3D GOMP_MAP_FLAG_PRESENT \ >> + || (X) =3D=3D GOMP_MAP_FORCE_PRESENT) > ..., and this 'GOMP_MAP_PRESENT_P' should look for > 'GOMP_MAP_FLAG_ALWAYS_PRESENT' instead of 'GOMP_MAP_FLAG_PRESENT' (plus > 'GOMP_MAP_FORCE_PRESENT')? > > Instead of the current effective 'GOMP_MAP_FLAG_ALWAYS_PRESENT': > > GOMP_MAP_FLAG_SPECIAL_0 > | GOMP_MAP_FLAG_SPECIAL_2 > | GOMP_MAP_FLAG_SPECIAL_5 > > ..., it could/should use a simpler flag combination? (My idea is that > this later make usage of flag bits for other purposes easier -- but I've > not verified that in depth.) I concur that it would be useful to save that space. We do not fully rule out other combinations as we can always move to check single values instead of comparing bit patterns, but I concur, reserving flags would be useful. Can you propose some bit pattern to use? Attached are the currently used ones (binary, hex, and decimal). Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------aNJvh57xhucl9JPTa4Nedmga Content-Type: text/plain; charset="UTF-8"; name="bitpattern.txt" Content-Disposition: attachment; filename="bitpattern.txt" Content-Transfer-Encoding: base64 MTAwMDAwMDAwCTB4MTAwCTI1NglHT01QX01BUF9MQVNUCjAwMDAwMDAwMAkweDAwMAkgIDAJ R09NUF9NQVBfQUxMT0MKMDAwMDAwMDAxCTB4MDAxCSAgMQlHT01QX01BUF9UTwowMDAwMDAw MTAJMHgwMDIJICAyCUdPTVBfTUFQX0ZST00KMDAwMDAwMDExCTB4MDAzCSAgMwlHT01QX01B UF9UT0ZST00KMDAwMDAwMTAwCTB4MDA0CSAgNAlHT01QX01BUF9QT0lOVEVSCjAwMDAwMDEw MQkweDAwNQkgIDUJR09NUF9NQVBfVE9fUFNFVAowMDAwMDAxMTAJMHgwMDYJICA2CUdPTVBf TUFQX0ZPUkNFX1BSRVNFTlQKMDAwMDAwMTExCTB4MDA3CSAgNwlHT01QX01BUF9ERUxFVEUK MDAwMDAxMDAwCTB4MDA4CSAgOAlHT01QX01BUF9GT1JDRV9ERVZJQ0VQVFIKMDAwMDAxMDAx CTB4MDA5CSAgOQlHT01QX01BUF9ERVZJQ0VfUkVTSURFTlQKMDAwMDAxMDEwCTB4MDBhCSAx MAlHT01QX01BUF9MSU5LCjAwMDAwMTAxMQkweDAwYgkgMTEJR09NUF9NQVBfSUZfUFJFU0VO VAowMDAwMDExMDAJMHgwMGMJIDEyCUdPTVBfTUFQX0ZJUlNUUFJJVkFURQowMDAwMDExMDEJ MHgwMGQJIDEzCUdPTVBfTUFQX0ZJUlNUUFJJVkFURV9JTlQKMDAwMDAxMTEwCTB4MDBlCSAx NAlHT01QX01BUF9VU0VfREVWSUNFX1BUUgowMDAwMDExMTEJMHgwMGYJIDE1CUdPTVBfTUFQ X1pFUk9fTEVOX0FSUkFZX1NFQ1RJT04KMDEwMDAwMDAwCTB4MDgwCTEyOAlHT01QX01BUF9G T1JDRV9BTExPQwowMTAwMDAwMDEJMHgwODEJMTI5CUdPTVBfTUFQX0ZPUkNFX1RPCjAxMDAw MDAxMAkweDA4MgkxMzAJR09NUF9NQVBfRk9SQ0VfRlJPTQowMTAwMDAwMTEJMHgwODMJMTMx CUdPTVBfTUFQX0ZPUkNFX1RPRlJPTQowMDAwMTAwMDAJMHgwMTAJIDE2CUdPTVBfTUFQX1VT RV9ERVZJQ0VfUFRSX0lGX1BSRVNFTlQKMDAwMDEwMDAxCTB4MDExCSAxNwlHT01QX01BUF9B TFdBWVNfVE8KMDAwMDEwMDEwCTB4MDEyCSAxOAlHT01QX01BUF9BTFdBWVNfRlJPTQowMDAw MTAwMTEJMHgwMTMJIDE5CUdPTVBfTUFQX0FMV0FZU19UT0ZST00KMDEwMDEwMTAxCTB4MDk1 CTE0OQlHT01QX01BUF9BTFdBWVNfUFJFU0VOVF9UTwowMTAwMTAxMTAJMHgwOTYJMTUwCUdP TVBfTUFQX0FMV0FZU19QUkVTRU5UX0ZST00KMDEwMDEwMTExCTB4MDk3CTE1MQlHT01QX01B UF9BTFdBWVNfUFJFU0VOVF9UT0ZST00KMDAwMDExMTAwCTB4MDFjCSAyOAlHT01QX01BUF9T VFJVQ1QKMDAwMDExMTAxCTB4MDFkCSAyOQlHT01QX01BUF9BTFdBWVNfUE9JTlRFUgowMDAw MTExMTAJMHgwMWUJIDMwCUdPTVBfTUFQX1BPSU5URVJfVE9fWkVST19MRU5HVEhfQVJSQVlf U0VDVElPTgowMDAwMTExMTEJMHgwMWYJIDMxCUdPTVBfTUFQX0RFTEVURV9aRVJPX0xFTl9B UlJBWV9TRUNUSU9OCjAwMDAxMDExMQkweDAxNwkgMjMJR09NUF9NQVBfUkVMRUFTRQowMDEw MTAwMDAJMHgwNTAJIDgwCUdPTVBfTUFQX0FUVEFDSAowMDEwMTAwMDEJMHgwNTEJIDgxCUdP TVBfTUFQX0RFVEFDSAowMTEwMTAwMDEJMHgwZDEJMjA5CUdPTVBfTUFQX0ZPUkNFX0RFVEFD SAowMDEwMTAwMTAJMHgwNTIJIDgyCUdPTVBfTUFQX0FUVEFDSF9aRVJPX0xFTkdUSF9BUlJB WV9TRUNUSU9OCjEwMDAwMDAwMQkweDEwMQkyNTcJR09NUF9NQVBfRklSU1RQUklWQVRFX1BP SU5URVIKMTAwMDAwMDEwCTB4MTAyCTI1OAlHT01QX01BUF9GSVJTVFBSSVZBVEVfUkVGRVJF TkNFCjEwMDAwMDAxMQkweDEwMwkyNTkJR09NUF9NQVBfQVRUQUNIX0RFVEFDSAoxMDAwMDAx MDAJMHgxMDQJMjYwCUdPTVBfTUFQX1BSRVNFTlRfQUxMT0MKMTAwMDAwMTAxCTB4MTA1CTI2 MQlHT01QX01BUF9QUkVTRU5UX1RPCjEwMDAwMDExMAkweDEwNgkyNjIJR09NUF9NQVBfUFJF U0VOVF9GUk9NCjEwMDAwMDExMQkweDEwNwkyNjMJR09NUF9NQVBfUFJFU0VOVF9UT0ZST00K --------------aNJvh57xhucl9JPTa4Nedmga--