From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44586 invoked by alias); 18 Jul 2019 05:44:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44577 invoked by uid 89); 18 Jul 2019 05:44:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jul 2019 05:44:56 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I5hLK1070133 for ; Thu, 18 Jul 2019 01:44:53 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ttjbdhr55-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 01:44:53 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 06:44:51 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Jul 2019 06:44:48 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I5ilIT39715076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Jul 2019 05:44:47 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 50E3DA4051; Thu, 18 Jul 2019 05:44:47 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1426EA4053; Thu, 18 Jul 2019 05:44:45 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.147.99]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 18 Jul 2019 05:44:44 +0000 (GMT) Subject: Re: [PATCH, rs6000] Support vrotr3 for int vector types To: Segher Boessenkool Cc: GCC Patches , Jakub Jelinek , Richard Biener , richard.sandiford@arm.com, Bill Schmidt References: <232a38b1-76c2-476d-1be0-a1958e5624bb@linux.ibm.com> <20190715085929.GO2125@tucnak> <32f89c4f-cd2d-a7bd-16d2-26fed6bb5f56@linux.ibm.com> <27be90e6-4beb-5c4c-a163-9b136490d783@linux.ibm.com> <20190717134025.GJ20882@gate.crashing.org> From: "Kewen.Lin" Date: Thu, 18 Jul 2019 06:06:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190717134025.GJ20882@gate.crashing.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit x-cbid: 19071805-0020-0000-0000-00000354E80E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071805-0021-0000-0000-000021A8BDBF Message-Id: <83f8448e-3c59-8991-2176-729d87e08a86@linux.ibm.com> X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg01219.txt.bz2 Hi Segher, on 2019/7/17 ÏÂÎç9:40, Segher Boessenkool wrote: > Hi Kewen, > > On Wed, Jul 17, 2019 at 04:32:15PM +0800, Kewen.Lin wrote: >> Regression testing just launched, is it OK for trunk if it's bootstrapped >> and regresstested on powerpc64le-unknown-linux-gnu? > >> +;; Expanders for rotatert to make use of vrotl >> +(define_expand "vrotr3" >> + [(set (match_operand:VEC_I 0 "vint_operand") >> + (rotatert:VEC_I (match_operand:VEC_I 1 "vint_operand") >> + (match_operand:VEC_I 2 "vint_reg_or_const_vector")))] > > Having any rotatert in a define_expand or define_insn will regress. > > So, nope, sorry. > Thanks for clarifying! Since regression testing passed on powerpc64le,I'd like to double confirm the meaning of "regress", does it mean it's a regression from design view? Is it specific to rotatert and its related one like vrotr? If yes, it sounds we can't go with vrotr way. :( Thanks, Kewen