public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tobias Burnus <tobias@codesourcery.com>, gcc-patches@gcc.gnu.org
Cc: Thomas Schwinge <thomas@schwinge.name>
Subject: Re: [PATCH][nvptx, doc] Update misa and mptx, add march and march-map
Date: Wed, 30 Mar 2022 09:35:26 +0200	[thread overview]
Message-ID: <841318a1-8791-8ea9-8cee-f567c2d71f8c@suse.de> (raw)
In-Reply-To: <e49325ce-acc6-5168-f02d-6cb1622e6d45@codesourcery.com>

On 3/29/22 16:28, Tobias Burnus wrote:
> Hi Tom,
> 
> On 29.03.22 15:39, Tom de Vries wrote:
>> Any comments?
>> +(e.g.@: @samp{sm_35}).  Valid architecture strings are @samp{sm_30},
>> +@samp{sm_35}, @samp{sm_53} @samp{sm_70}, @samp{sm_75} and
>> +@samp{sm_80}.  The default target architecture is sm_30.
> 
> Missing comma (",") between sm_53 and sm_70.
> 

Ack, fixed.

> I want to note that the default is now back at sm_30;
> for GCC 11 it was changed to sm_35, cf. 
> https://gcc.gnu.org/gcc-11/changes.html

I think changes are better described in release notes.

> (We also need to update the wwwdocs release notes before the release, 
> but it
> can also be done after branching).
> 

Right, I'll follow up on your proposal from beginning of this month.

>> +@item -march-map=@var{architecture-string}
>> +@opindex march
>> +Select the closest available @option{-march=} value that is not more
>> +capable.  For instance, for @option{-march-map=sm_50} select
>> +@option{-march=sm_35}, and for @option{-march-map=sm_53} select
>> +@option{-march=sm_53}.
> 
> (Somehow, I am not completely happy with the wording, but, admittedly, I
> don't have a better suggestion.)

I feel the same, so committed as is.

Thanks,
- Tom

      parent reply	other threads:[~2022-03-30  7:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 13:39 Tom de Vries
2022-03-29 14:28 ` Tobias Burnus
2022-03-29 14:47   ` Tobias Burnus
2022-03-30  8:03     ` Tom de Vries
2022-03-30  9:02       ` Tobias Burnus
2022-03-30 11:45         ` Tom de Vries
2022-03-30  7:35   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=841318a1-8791-8ea9-8cee-f567c2d71f8c@suse.de \
    --to=tdevries@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=thomas@schwinge.name \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).