From: Jerry D <jvdelisle2@gmail.com>
To: Harald Anlauf <anlauf@gmx.de>, fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: *PING* [PATCH] PR fortran/99348, 102521 - ICEs when initializing DT parameter arrays from scalar
Date: Sat, 9 Oct 2021 17:58:18 -0700 [thread overview]
Message-ID: <8419cae8-2c2d-1bd1-c4e8-0b66f0ae6b0c@gmail.com> (raw)
In-Reply-To: <3ba4124c-0191-9f62-0bdd-5da19d9ad216@gmx.de>
This one looks OK. Sorry I missed it earlier. Thanks again for the patch!
Jerry
On 10/9/21 12:27 PM, Harald Anlauf via Fortran wrote:
> *Ping*
>
> Am 03.10.21 um 21:20 schrieb Harald Anlauf via Fortran:
>> Dear Fortranners,
>>
>> when initializing parameter arrays from scalars, we did handle only
>> the case init->expr_type == EXPR_CONSTANT, which misses the case of
>> derived types. As a consequence the constructor for the r.h.s. was
>> not set up, which later led to different ICEs.
>>
>> To solve this I looked at gfc_simplify_spread. I was contemplating
>> whether to also copy the logic to make this initialization dependent
>> on -fmax-array-constructor. I chose not to, because there is no
>> sensible and simple fallback available to handle that case while
>> allowing the access to array elements. We could instead make that
>> a warning.
>>
>> Comments / opinions?
>>
>> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>>
>> As this is an ICE on valid, potentially useful code,
>> I'd like to backport this to 11-branch.
>>
>> Thanks,
>> Harald
>>
>
>
prev parent reply other threads:[~2021-10-10 0:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 19:20 Harald Anlauf
2021-10-09 19:27 ` *PING* " Harald Anlauf
2021-10-10 0:58 ` Jerry D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8419cae8-2c2d-1bd1-c4e8-0b66f0ae6b0c@gmail.com \
--to=jvdelisle2@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).