From: Tobias Burnus <tobias@codesourcery.com>
To: "Martin Liška" <mliska@suse.cz>, "Jakub Jelinek" <jakub@redhat.com>
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC] Port git gcc-descr to Python
Date: Thu, 14 Oct 2021 11:06:55 +0200 [thread overview]
Message-ID: <846ffa97-c2c4-2dd4-9d02-ed6db5d1ffa7@codesourcery.com> (raw)
In-Reply-To: <12d44ac0-8849-466c-9749-b4e1e7168ac7@suse.cz>
Hi Martin,
On 12.10.21 10:59, Martin Liška wrote:
> There's a complete patch that implements both git gcc-descr and
> gcc-undesrc
> and sets corresponding git aliases to use them.
When invoking ./contrib/git-describe.py directly, I get the error:
fatal: Not a valid object name /master
I think you need something like:
- upstream = r.stdout.strip() if r.returncode else 'origin'
+ upstream = r.stdout.strip() if r.returncode == 0 else 'origin'
* * *
Additionally, I observe the following (independent of the conversion):
For 7433458d871f6bfe2169b9d7d04fec64bb142924, I get:
r0-80854-g7433458d871f6b
The question is whether we are happy that only reversions since
basepoints/gcc-5 have a version number or whether we want to
use releases/gcc-x.y.0 -> x.y as fallback when basepoint does not
exist or back-added more basepoints? Admittedly, this will add '.',
thus, maybe the answer is 'no'?
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2021-10-14 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 11:01 [PATCH] contrib: git gcc-descr defaulting to print hash Martin Liška
2021-10-08 11:12 ` Jakub Jelinek
2021-10-11 12:32 ` [RFC] Port git gcc-descr to Python Martin Liška
2021-10-12 8:59 ` Martin Liška
2021-10-14 9:06 ` Tobias Burnus [this message]
2021-10-14 9:19 ` Jakub Jelinek
2021-10-18 9:01 ` Martin Liška
2022-01-19 11:01 ` Martin Liška
2022-01-19 12:49 ` Martin Jambor
2022-01-19 13:17 ` Martin Liška
2022-01-19 16:54 ` Eric Gallager
2022-01-27 15:06 ` [PATCH] contrib: Put gcc-descr and gcc-undescr to file Martin Liška
2022-01-27 15:35 ` Jakub Jelinek
2022-01-27 17:44 ` Martin Liška
2022-01-27 15:51 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=846ffa97-c2c4-2dd4-9d02-ed6db5d1ffa7@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely.gcc@gmail.com \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).