From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 348733858D28 for ; Tue, 15 Mar 2022 13:53:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 348733858D28 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22FDLXjM027621; Tue, 15 Mar 2022 13:53:17 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3etum20r77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Mar 2022 13:53:17 +0000 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 22FDo9XT008819; Tue, 15 Mar 2022 13:53:17 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 3etum20r6t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Mar 2022 13:53:17 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22FDrDld023879; Tue, 15 Mar 2022 13:53:16 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma01dal.us.ibm.com with ESMTP id 3erk59jygw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Mar 2022 13:53:16 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22FDrFZj48759262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Mar 2022 13:53:15 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1824712405E; Tue, 15 Mar 2022 13:53:15 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 54FAC124062; Tue, 15 Mar 2022 13:53:14 +0000 (GMT) Received: from [9.77.152.28] (unknown [9.77.152.28]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 15 Mar 2022 13:53:14 +0000 (GMT) Message-ID: <847278b0-ed3d-a833-a83d-4370d42e3f65@linux.ibm.com> Date: Tue, 15 Mar 2022 08:53:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] rs6000: Fix invalid address passed to __builtin_mma_disassemble_acc [PR104923] Content-Language: en-US From: Peter Bergner To: Segher Boessenkool Cc: David Edelsohn , GCC Patches References: <20220315012425.GH614@gate.crashing.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: fdfplcAhwraKqsOzAbzPYwa6owl30-F2 X-Proofpoint-GUID: ayeR7jFm0u79p7LC50fBO2BiOvsQsdj8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-15_03,2022-03-15_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 mlxlogscore=892 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203150089 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 13:53:20 -0000 On 3/14/22 10:06 PM, Peter Bergner wrote: > On 3/14/22 8:24 PM, Segher Boessenkool wrote: >> You might want to name that common expression, "rtx addr = XEXP (op, 0);" >> or something. Dunno what is best > > Will do. > > >> Please put that new MEM_P code first, followed by a blank line, and only >> then do the SUBREG thing. As written it will allow subregs of mem. And >> the blank line is important of course ;-) > > Will do. > > >> Okay for trunk with those changes. Also okay for 10 and 11 after an >> appropriate soak period. Thanks! Testing of the updates came back clean so I pushed the fix. I'll wait a few days before pushing the backports. Thanks! Peter