* Re: [patch,libgomp] Make libgomp Fortran modules multilib-aware [not found] ` <AD0AE248-C557-4A37-87C5-BFE14DCA4F96@gmail.com> @ 2016-12-26 11:28 ` FX 2017-01-09 10:04 ` FX 0 siblings, 1 reply; 3+ messages in thread From: FX @ 2016-12-26 11:28 UTC (permalink / raw) To: GCC Patches; +Cc: Jack Howarth, Richard Henderson, Jakub Jelinek [-- Attachment #1: Type: text/plain, Size: 153 bytes --] *ping* This patch from May makes libgomp install its Fortran modules in the correct multilib-aware directories, following what libgfortran does. [-- Attachment #2: patch.txt --] [-- Type: text/plain, Size: 612 bytes --] Index: libgomp/Makefile.am =================================================================== --- libgomp/Makefile.am (revision 235843) +++ libgomp/Makefile.am (working copy) @@ -10,7 +10,7 @@ config_path = @config_path@ search_path = $(addprefix $(top_srcdir)/config/, $(config_path)) $(top_srcdir) \ $(top_srcdir)/../include -fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/finclude +fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)$(MULTISUBDIR)/finclude libsubincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/include vpath % $(strip $(search_path)) [-- Attachment #3: Type: text/plain, Size: 789 bytes --] > The attached patch allows libgomp to install its Fortran modules in the correct multilib-aware directories, just like libgfortran does. > Without it, multilib Fortran OpenMP code using the modules fails to compile because the modules are not found: > > $ gfortran -fopenmp a.f90 > $ gfortran -fopenmp a.f90 -m32 > a.f90:1:6: > > use omp_lib > 1 > Fatal Error: Can't open module file ‘omp_lib.mod’ for reading at (1): No such file or directory > compilation terminated. > > > > Bootstrapped and tested on x86_64-apple-darwin15. OK to commit? > > FX > > > > > > > 2016-05-03 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org> > > PR libgomp/60670 > * Makefile.am: Make fincludedir multilib-aware. > * Makefile.in: Regenerate. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch,libgomp] Make libgomp Fortran modules multilib-aware 2016-12-26 11:28 ` [patch,libgomp] Make libgomp Fortran modules multilib-aware FX @ 2017-01-09 10:04 ` FX 2017-01-09 18:50 ` Mike Stump 0 siblings, 1 reply; 3+ messages in thread From: FX @ 2017-01-09 10:04 UTC (permalink / raw) To: Jack Howarth, Richard Henderson, Jakub Jelinek; +Cc: GCC Patches, Fortran List [-- Attachment #1: Type: text/plain, Size: 118 bytes --] Given lack of review of this Fortran-specific patch for libgomp, can a Fortran maintainer approve it please? FX [-- Attachment #2: patch.txt --] [-- Type: text/plain, Size: 612 bytes --] Index: libgomp/Makefile.am =================================================================== --- libgomp/Makefile.am (revision 235843) +++ libgomp/Makefile.am (working copy) @@ -10,7 +10,7 @@ config_path = @config_path@ search_path = $(addprefix $(top_srcdir)/config/, $(config_path)) $(top_srcdir) \ $(top_srcdir)/../include -fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/finclude +fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)$(MULTISUBDIR)/finclude libsubincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/include vpath % $(strip $(search_path)) [-- Attachment #3: Type: text/plain, Size: 988 bytes --] > *ping* > > This patch from May makes libgomp install its Fortran modules in the correct multilib-aware directories, following what libgfortran does. > > > > >> The attached patch allows libgomp to install its Fortran modules in the correct multilib-aware directories, just like libgfortran does. >> Without it, multilib Fortran OpenMP code using the modules fails to compile because the modules are not found: >> >> $ gfortran -fopenmp a.f90 >> $ gfortran -fopenmp a.f90 -m32 >> a.f90:1:6: >> >> use omp_lib >> 1 >> Fatal Error: Can't open module file ‘omp_lib.mod’ for reading at (1): No such file or directory >> compilation terminated. >> >> >> >> Bootstrapped and tested on x86_64-apple-darwin15. OK to commit? >> >> FX >> >> >> >> >> >> >> 2016-05-03 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org> >> >> PR libgomp/60670 >> * Makefile.am: Make fincludedir multilib-aware. >> * Makefile.in: Regenerate. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch,libgomp] Make libgomp Fortran modules multilib-aware 2017-01-09 10:04 ` FX @ 2017-01-09 18:50 ` Mike Stump 0 siblings, 0 replies; 3+ messages in thread From: Mike Stump @ 2017-01-09 18:50 UTC (permalink / raw) To: FX Cc: Jack Howarth, Richard Henderson, Jakub Jelinek, GCC Patches, Fortran List On Jan 9, 2017, at 2:04 AM, FX <fxcoudert@gmail.com> wrote: > > Given lack of review of this Fortran-specific patch for libgomp, can a Fortran maintainer approve it please? Ok. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-09 18:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <4795FF84-EC6B-448F-991E-AAA8948D5EE4@gmail.com>
[not found] ` <CAJMcOU-k8ni+y05YH6CaxH3KAmHNjSYkXAqs-NYPWaNztK+Xtw@mail.gmail.com>
[not found] ` <93D9F5BF-2BFD-4DC9-957E-EB3CAA41E7D9@gmail.com>
[not found] ` <AD0AE248-C557-4A37-87C5-BFE14DCA4F96@gmail.com>
2016-12-26 11:28 ` [patch,libgomp] Make libgomp Fortran modules multilib-aware FX
2017-01-09 10:04 ` FX
2017-01-09 18:50 ` Mike Stump
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).