From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 2D13D3858D37 for ; Tue, 21 Mar 2023 12:35:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D13D3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="101041541" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 21 Mar 2023 04:35:25 -0800 IronPort-SDR: U0M6bS3Uv8yxjG5IC3RD7B/B5+VOi2vXlSJWC7SOMgff4ZGpYrSDRl+OK2XiV1BAxLuZh3zOtI Dof+fPhxwDi88dg2T+IbevzdiYuczcSR70jmCVexVvizibKqaYiLprdWgQTOLN4RrNJxjeDD30 C9MG/+slZXefRPJd6wFKqDuRYJckChpGbyWujN3iPEbWD5djq6wvl+3mWt2/nlITG7AjCakXQE hTdOeB7nHKVxirnwyNnqhv+r7u9UhLjyCJIUS/XQNjsg5hMBSsbQBbZL+HiH3rYILsOUNjfQ9R C6A= Message-ID: <8498f85f-ad54-0148-0286-2442ff878e24@codesourcery.com> Date: Tue, 21 Mar 2023 12:35:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] testsuite: Fix up vect-simd-clone1[678]*.c tests [PR108898] To: Jakub Jelinek , Richard Biener CC: References: Content-Language: en-GB From: Andrew Stubbs In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/03/2023 12:14, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, vect-simd-clone-1[678]{,f}.c tests FAIL on > x86_64-linux with -m64/-march=cascadelake or -m32/-march=cascadelake, > there are 3 matches for the calls rather than expected two. > As suggested by Richi, this patch changes those tests to use > --param vect-epilogues-nomask=0 such that it is more predictable on how > many calls will show up. In the non-[a-f] suffixed tests, the Thanks for doing this. I've had it on my to-do list but not got there yet. > scan-tree-dump-times patterns were expecting 2 for non-aarch64 and 3 for > aarch64, which is a puzzle for me, because vect_simd_clones effective > target is apparently never true on aarch64 (just on x86 in some cases and > on amdgcn; perhaps something to change for GCC14, but I guess too late > for stage4). That said, I have looked at aarch64 dumps and see only 2 > calls with --param vect-epilogues-nomask=0 and 3 with --param > vect-epilogues-nomask=1 or without it, so I have tweaked those to always > expect the same thing. Another thing is some tests uselessly had > -fdump-tree-optimized in dg-options even when they don't scan anything > there. I believe I did mention when I posted the original patch that I tested enabling vect_simd_clones on AArch64, but found that there were other failures. I made sure that the expected results were right in the new tests, but did not enable the effective target for this reason. > > Tested on x86_64-linux with > make -j32 -k check-gcc RUNTESTFLAGS="vect.exp=gcc.dg/vect/vect-simd-clone-*.c --target_board='unix{-m64/-march=x86-64,-m64/-march=cascadelake,-m32/-march=i686,-m32/-march=cascadelake}'" > and aarch64-linux (where all tests are UNSUPPORTED before/after), ok for > trunk? > > 2023-03-21 Jakub Jelinek > > PR testsuite/108898 > * gcc.dg/vect/vect-simd-clone-16.c: Add --param vect-epilogues-nomask=0 > to dg-additional-options. Always expect just 2 foo.simdclone calls. > * gcc.dg/vect/vect-simd-clone-16f.c: Add > --param vect-epilogues-nomask=0 to dg-additional-options. > * gcc.dg/vect/vect-simd-clone-17.c: Likewise. Always expect just 2 > foo.simdclone calls. > * gcc.dg/vect/vect-simd-clone-17d.c: Remove -fdump-tree-optimized from > dg-additional-options. > * gcc.dg/vect/vect-simd-clone-17e.c: Likewise. > * gcc.dg/vect/vect-simd-clone-17f.c: Likewise. Add > --param vect-epilogues-nomask=0 to dg-additional-options. > * gcc.dg/vect/vect-simd-clone-18.c: Add --param vect-epilogues-nomask=0 > to dg-additional-options. Always expect just 2 foo.simdclone calls. > * gcc.dg/vect/vect-simd-clone-18f.c: Add > --param vect-epilogues-nomask=0 to dg-additional-options. > > --- gcc/testsuite/gcc.dg/vect/vect-simd-clone-16.c.jj 2023-02-22 15:58:59.661862434 +0100 > +++ gcc/testsuite/gcc.dg/vect/vect-simd-clone-16.c 2023-03-21 12:21:44.084547190 +0100 > @@ -1,5 +1,5 @@ > /* { dg-require-effective-target vect_simd_clones } */ > -/* { dg-additional-options "-fopenmp-simd" } */ > +/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */ > /* { dg-additional-options "-mavx" { target avx_runtime } } */ > > /* Test that simd inbranch clones work correctly. */ > @@ -82,8 +82,7 @@ main () > > /* Ensure the the in-branch simd clones are used on targets that support them. > Some targets use another call for the epilogue loops. */ > -/* { dg-final { scan-tree-dump-times {[\n\r] [^\n]* = foo\.simdclone} 2 "vect" { target { ! aarch64*-*-* } } } } */ > -/* { dg-final { scan-tree-dump-times {[\n\r] [^\n]* = foo\.simdclone} 3 "vect" { target aarch64*-*-* } } } */ > +/* { dg-final { scan-tree-dump-times {[\n\r] [^\n]* = foo\.simdclone} 2 "vect" } } */ I suppose those comments are now obsolete. Andrew