From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 602 invoked by alias); 14 Jul 2017 07:40:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 564 invoked by uid 89); 14 Jul 2017 07:40:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=spread, Hx-languages-length:755, HContent-Transfer-Encoding:8bit X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 07:40:01 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5E7E4AAB9; Fri, 14 Jul 2017 07:39:59 +0000 (UTC) Subject: Re: [RFC][PATCH] Do refactoring of attribute functions and move them to attribs.[hc]. To: Jeff Law , Jason Merrill Cc: Joseph Myers , gcc-patches List , Richard Biener References: <1856059e-e9b1-63d2-717f-e20ec171b329@suse.cz> <4cf00ee9-4cd7-1806-481f-966611768a15@suse.cz> <8a0b2ff0-50f9-771d-fb63-01d17cb06b46@suse.cz> <669c960e-f4a8-eae3-efd2-f8c29477a817@suse.cz> <7e541554-10a6-9cae-fca0-042900271768@suse.cz> <2039ae2c-a523-1850-4d98-598cbd03b498@redhat.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <84a631f3-132c-b234-7486-ef222ff8d46f@suse.cz> Date: Fri, 14 Jul 2017 07:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <2039ae2c-a523-1850-4d98-598cbd03b498@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00800.txt.bz2 On 07/14/2017 09:23 AM, Jeff Law wrote: > On 07/13/2017 07:51 AM, Martin Liška wrote: >> Hi. >> >> It's request for comment where I mechanically moved attribute-related function to attribs.[hc]. >> >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. >> >> Thoughts? > Seems reasonable. We don't like to move things around without a good > reason and I assume you've got something in mind? Well, I basically identified that attribute-related functions are spread in between attribs.[ch] and tree.c[ch]. And as the later ones are quite big, the code movement logical to me. I'm going to prepare changelog entry for that. Martin > > jeff >