From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 897AB3844758 for ; Tue, 14 May 2024 08:43:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 897AB3844758 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 897AB3844758 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715676232; cv=none; b=ieTSvUfgECg11x1ak/4wN9IcKUq+MsXENaQuvYo82EJEnpGSnh4H5KB2HhWVnqtMipKvaUL3gV3IWfZMKsQau+87SYYs2fT8LQFyxC5y00yX9NshXdCx8MD10FnVlcRmMWENespe2WbekCMDeHgPttyNEshMTid5LHGy9nTWuQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715676232; c=relaxed/simple; bh=oIeeasa0trNT3z/n6SDXXpHsoMaKK64nqSazOHVGaf8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=j7SMO3Y/8TW6d3zgcHvlgT3Y3K8YXtesjOTOIsboHs2VWaIL+Kc9aG/sznp45MAkdCfQvhAD9lk0Aw6UTCMqg8QPKpmwSuA7uCYBDNWiyWO+aQKo18ZFyMJ1/I+Zaavu8ATpFNUlxQ0C5cKEc2J6aq4HYRrpnuhPMKIBHotkpNo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44E6vZPt022293; Tue, 14 May 2024 08:43:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : references : cc : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=MLbadbHelhibP9WtaSxDHMAizW3XOd6eRlIidp3O9Rw=; b=oqB7iXhFGIXN5e+NQpRxS1FqTh9ahBNeys0eX04VPBRjboEJCyxO/JgEceF9qsdaZYTB OqIqGA4bhjh7O0alQUBz6u1r09dC1AewpRvKWpxCh6C4yzGL7q0JPGAfrk+NBqpB/joI hfMLOhbneluoGVlN2KgjSvB602LPDniTQQ5p1ngkAWV4dBvLfGZ6e2/7uNzx9wd+IXTx YGJluQxYpyybYhMdqbtkB6jlNn4DFgivquZDw97Yh1mNIy7eICFRQa2EeW3U29UCvZ9J O/9otNmnuewZOgUli46FaGK+1vjArCQ8uu8LEFn3yG6Xcb+hbukAIEep71rziE17FK4s sA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y427vgc86-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 08:43:46 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 44E8hkER017749; Tue, 14 May 2024 08:43:46 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y427vgc84-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 08:43:46 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 44E8L1wc002257; Tue, 14 May 2024 08:43:45 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3y2m0p4dar-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 08:43:45 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 44E8hd8f24838798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2024 08:43:41 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B5A1A2004B; Tue, 14 May 2024 08:43:39 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E16C720040; Tue, 14 May 2024 08:43:37 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 14 May 2024 08:43:37 +0000 (GMT) Message-ID: <84a8137c-a1ed-eaac-6f1d-a5a54a1a426f@linux.ibm.com> Date: Tue, 14 May 2024 16:43:30 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/13] rs6000, Remove __builtin_vsx_xvcvspsxws built-in Content-Language: en-US To: Carl Love References: <6378d560-df55-4b75-be7b-93dc6b85d81a@linux.ibm.com> <03b7f195-bc29-4350-99fc-42afba626c34@linux.ibm.com> Cc: gcc-patches@gcc.gnu.org, "bergner@linux.ibm.com" , Segher Boessenkool , David Edelsohn From: "Kewen.Lin" In-Reply-To: <03b7f195-bc29-4350-99fc-42afba626c34@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: VJAbpG4sUP5p6HuhzqaAEF3kR-68Uo7j X-Proofpoint-GUID: GfFbxw0EXlCR9EckmVCtCQoc8bkG5hi5 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-14_03,2024-05-10_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 adultscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405140060 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, on 2024/4/20 05:17, Carl Love wrote: > rs6000, Remove __builtin_vsx_xvcvspsxws built-in > > The built-in __builtin_vsx_xvcvspsxws is a duplicate of the vec_signed > built-in that is documented in the PVIPR. The __builtin_vsx_xvcvspsxws > built-in is not documented and there are no test cases for it. > > This patch removes the redundant built-in. By revisiting the comments on the previous version: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/646723.html I wonder if it's intentional to keep the others, at least bifs __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws and __builtin_vsx_xvcvuxddp_uns looks removable, users can just uses the equivalent ones in PVIPR. And for the others, users can still use the PVIPR ones by considering endianness (controlling with endianness macros). BR, Kewen > > gcc/ChangeLog: > * config/rs6000/rs6000-builtins.def (__builtin_vsx_xvcvspsxws): > Remove built-in definition. > --- > gcc/config/rs6000/rs6000-builtins.def | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def > index 7c36976a089..c6d2ea1bc39 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -1709,9 +1709,6 @@ > const vsll __builtin_vsx_xvcvspsxds (vf); > XVCVSPSXDS vsx_xvcvspsxds {} > > - const vsi __builtin_vsx_xvcvspsxws (vf); > - XVCVSPSXWS vsx_fix_truncv4sfv4si2 {} > - > const vsll __builtin_vsx_xvcvspuxds (vf); > XVCVSPUXDS vsx_xvcvspuxds {} >