public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Indu Bhagat <indu.bhagat@oracle.com>
To: David Faust <david.faust@oracle.com>, gcc-patches@gcc.gnu.org
Cc: Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH v4 4/6] btf: add -gprune-btf option
Date: Mon, 24 Jun 2024 11:32:27 -0700	[thread overview]
Message-ID: <84ef23fd-64c1-4bcb-b9ae-8465f240146c@oracle.com> (raw)
In-Reply-To: <1c475f7e-9d2a-46c0-9869-4403bfbdfd40@oracle.com>

On 6/24/24 09:11, David Faust wrote:
> Ping.
> 
> Richard: I changed the option name as you asked but forgot to CC you on
> the updated patch.  Is the new option OK?
> 
> Indu: You had some minor comments on the prior version which I have
> addressed, not sure whether you meant the rest of the patch was OK or
> not, or if you had a chance to review it.
> 

Hi David,

Thanks for making the change in the commit message to clearly state the 
behavior of the option -gprune-btf with and without LTO build.  I did 
take a look at the V3 version of the patch, had tested it a bit too.

While there are still remain some gaps in my understanding of the 
algorithm, but overall I think this patch as such looks good and makes 
forward progress.

So, LGTM.

Thanks
Indu

> Thanks!
> 
> archive:https://gcc.gnu.org/pipermail/gcc-patches/2024-June/654252.html


  reply	other threads:[~2024-06-24 18:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 19:01 [PATCH v4 0/6] btf: refactor and add pruning option David Faust
2024-06-11 19:01 ` [PATCH v4 1/6] ctf, btf: restructure CTF/BTF emission David Faust
2024-06-11 19:01 ` [PATCH v4 2/6] ctf: use pointers instead of IDs internally David Faust
2024-06-11 19:01 ` [PATCH v4 3/6] btf: refactor and simplify implementation David Faust
2024-06-11 19:01 ` [PATCH v4 4/6] btf: add -gprune-btf option David Faust
2024-06-24 16:11   ` David Faust
2024-06-24 18:32     ` Indu Bhagat [this message]
2024-06-11 19:01 ` [PATCH v4 5/6] bpf,btf: enable BTF pruning by default for BPF David Faust
2024-06-12 16:55   ` Jose E. Marchesi
2024-06-12 17:40     ` David Faust
2024-06-12 18:46       ` Jose E. Marchesi
2024-06-11 19:01 ` [PATCH v4 6/6] opts: allow any combination of DWARF, CTF, BTF David Faust
2024-06-24 16:13   ` David Faust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84ef23fd-64c1-4bcb-b9ae-8465f240146c@oracle.com \
    --to=indu.bhagat@oracle.com \
    --cc=david.faust@oracle.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).