From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Kaveh R. GHAZI" <ghazi@caip.rutgers.edu>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH]: PR middle-end/31796 use MPFR to evaluate remquo/remainder/drem at compile-time
Date: Thu, 17 May 2007 09:59:00 -0000 [thread overview]
Message-ID: <84fc9c000705170259w2a47211p19e1d08c60041d89@mail.gmail.com> (raw)
In-Reply-To: <Pine.GSO.4.58.0705051328590.14660@caipclassic.rutgers.edu>
On 5/5/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> This patch address PR middle-end/31796. It uses MPFR to evaluate remquo,
> remainder and drem at compile-time when they are supplied with constant
> arguments.
>
> This patch relies on the follow two previous (and as yet unreviewed)
> patches to apply cleanly:
>
> http://gcc.gnu.org/ml/gcc-patches/2007-04/msg01624.html
> http://gcc.gnu.org/ml/gcc-patches/2007-04/msg01663.html
>
> Tested on sparc-sun-solaris2.10, no regressions and the new tests all
> pass.
>
> Okay for mainline?
This is ok if you XFAIL the testcases that require new mpfr. Also please
consider adding new testcase files for those that need XFAILing (I
suppose builtin-math-4.c is from some other patch taht did not went in
yet).
Richard.
:REVIEWMAIL:
> Thanks,
> --Kaveh
>
> :ADDPATCH middle-end:
>
>
> 2007-05-05 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> PR middle-end/31796
> * builtins.c (do_mpfr_remquo): New.
> (fold_builtin_2): Handle BUILT_IN_DREM/BUILT_IN_REMAINDER.
> (fold_builtin_3): Handle BUILT_IN_REMQUO.
>
> testsuite:
> * gcc.dg/torture/builtin-math-2.c: Add tests for remquo, remainder
> and drem.
> * gcc.dg/torture/builtin-math-4.c: Likewise.
>
next prev parent reply other threads:[~2007-05-17 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 17:31 Kaveh R. GHAZI
2007-05-17 9:59 ` Richard Guenther [this message]
2007-05-18 2:36 ` Kaveh R. GHAZI
2007-05-18 2:41 ` Andrew Pinski
2007-05-18 3:07 ` Kaveh R. GHAZI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fc9c000705170259w2a47211p19e1d08c60041d89@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ghazi@caip.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).