From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Kaveh R. GHAZI" <ghazi@caip.rutgers.edu>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH]: PR middle-end/30250, use MPFR for lgamma_r/gamma_r
Date: Wed, 23 May 2007 21:53:00 -0000 [thread overview]
Message-ID: <84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com> (raw)
In-Reply-To: <Pine.GSO.4.58.0705190020280.10677@caipclassic.rutgers.edu>
On 5/19/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> On Thu, 17 May 2007, Richard Guenther wrote:
>
> > > + /* Dereference the arg_sg pointer argument. */
> > > + arg_sg = build_fold_indirect_ref (arg_sg);
> > > + /* Proceed iff a valid pointer type was passed in. */
> > > + if (TYPE_MAIN_VARIANT (TREE_TYPE (arg_sg)) == integer_type_node)
> >
> > This check should be done earlier based on the pointed to type of the
> > argument. Ok with this change.
>
> Done. I installed the revised patch below. Thanks again for your
> reviews.
This:
/* Expect failures at least until mpfr-2.3.0 is released. */
/* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */
doesn't work. Or did you forget a testsuite/lib patch?
Richard.
next prev parent reply other threads:[~2007-05-23 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 16:04 Kaveh R. GHAZI
2007-05-17 10:15 ` Richard Guenther
2007-05-19 4:23 ` Kaveh R. GHAZI
2007-05-23 21:53 ` Richard Guenther [this message]
2007-05-23 22:57 ` Kaveh R. GHAZI
2007-05-24 8:15 ` Richard Guenther
2007-05-24 10:16 ` Richard Guenther
2007-05-24 16:59 ` Janis Johnson
2007-05-24 21:09 ` Kaveh R. GHAZI
2007-05-24 22:43 ` Janis Johnson
2007-05-24 16:46 ` Joe Buck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ghazi@caip.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).