From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-195564-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 20308 invoked by alias); 23 May 2007 21:53:45 -0000
Received: (qmail 20299 invoked by uid 22791); 23 May 2007 21:53:45 -0000
X-Spam-Check-By: sourceware.org
Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.175)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 May 2007 21:53:43 +0000
Received: by ug-out-1314.google.com with SMTP id u2so834943uge         for <gcc-patches@gcc.gnu.org>; Wed, 23 May 2007 14:53:41 -0700 (PDT)
Received: by 10.67.40.12 with SMTP id s12mr1664110ugj.1179957221174;         Wed, 23 May 2007 14:53:41 -0700 (PDT)
Received: by 10.67.16.4 with HTTP; Wed, 23 May 2007 14:53:41 -0700 (PDT)
Message-ID: <84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com>
Date: Wed, 23 May 2007 21:53:00 -0000
From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Kaveh R. GHAZI" <ghazi@caip.rutgers.edu>
Subject: Re: [PATCH]: PR middle-end/30250, use MPFR for lgamma_r/gamma_r
Cc: gcc-patches@gcc.gnu.org
In-Reply-To: <Pine.GSO.4.58.0705190020280.10677@caipclassic.rutgers.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <Pine.GSO.4.58.0705071202240.25493@caipclassic.rutgers.edu> 	 <84fc9c000705170315g15b30422ga7884f0779c17003@mail.gmail.com> 	 <Pine.GSO.4.58.0705190020280.10677@caipclassic.rutgers.edu>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-05/txt/msg01580.txt.bz2

On 5/19/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> On Thu, 17 May 2007, Richard Guenther wrote:
>
> > > +             /* Dereference the arg_sg pointer argument.  */
> > > +             arg_sg = build_fold_indirect_ref (arg_sg);
> > > +             /* Proceed iff a valid pointer type was passed in.  */
> > > +             if (TYPE_MAIN_VARIANT (TREE_TYPE (arg_sg)) == integer_type_node)
> >
> > This check should be done earlier based on the pointed to type of the
> > argument. Ok with this change.
>
> Done.  I installed the revised patch below.  Thanks again for your
> reviews.

This:

/* Expect failures at least until mpfr-2.3.0 is released. */
/* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */

doesn't work.  Or did you forget a testsuite/lib patch?

Richard.