From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21927 invoked by alias); 9 Jul 2007 12:34:54 -0000 Received: (qmail 21916 invoked by uid 22791); 9 Jul 2007 12:34:53 -0000 X-Spam-Check-By: sourceware.org Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.181) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Jul 2007 12:34:52 +0000 Received: by py-out-1112.google.com with SMTP id a29so2187416pyi for ; Mon, 09 Jul 2007 05:34:50 -0700 (PDT) Received: by 10.65.141.18 with SMTP id t18mr1561737qbn.1183984490165; Mon, 09 Jul 2007 05:34:50 -0700 (PDT) Received: by 10.65.177.11 with HTTP; Mon, 9 Jul 2007 05:34:50 -0700 (PDT) Message-ID: <84fc9c000707090534y718191c3ye7e98d4ea12f2ee0@mail.gmail.com> Date: Mon, 09 Jul 2007 12:40:00 -0000 From: "Richard Guenther" To: "Paolo Bonzini" Subject: Re: PR/32004, tree-ssa caused in/out asm constraints to often need reloads Cc: "Eric Botcazou" , "Andrew Pinski" , gcc-patches@gcc.gnu.org, "Mark Mitchell" In-Reply-To: <469228F7.6020601@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <468CC82F.2060702@lu.unisi.ch> <200707072023.25902.ebotcazou@adacore.com> <4691965D.703@gnu.org> <200707090748.59581.ebotcazou@adacore.com> <469228F7.6020601@gnu.org> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg00784.txt.bz2 On 7/9/07, Paolo Bonzini wrote: > Eric Botcazou wrote: > >> I will look at it and may eventually revert it, but I'll note that this > >> "brand new pass" just adds a few (set (reg) (reg)). > > > > Please remove it from the 4.1 branch, you didn't get approval to put it there > > and you apparently didn't even test it there, causing the first regressions > > in months on the branch. > > Actually it is fixed by this trivial patch. Ok for 4.2/4.1? Assuming you have tested the patch on the branches, yes. Richard. > Paolo > > Index: ../base-gcc-src/gcc/function.c > =================================================================== > --- ../base-gcc-src/gcc/function.c (revision 126418) > +++ ../base-gcc-src/gcc/function.c (working copy) > @@ -5713,7 +5713,7 @@ rest_of_match_asm_constraints (void) > } > > update_life_info_in_dirty_blocks (UPDATE_LIFE_GLOBAL_RM_NOTES, > - PROP_DEATH_NOTES); > + PROP_DEATH_NOTES | PROP_REG_INFO); > return 0; > } > > >