PATCH: PR fortran/33646: [4.3 Regression] Gcc 4.3 revision 128954 failed tonto in SPEC CPU 2006

PATCH: PR fortran/33646: [4.3 Regression] Gcc 4.3 revision 128954 failed tonto in SPEC CPU 2006

[H.J. Lu]

This patch adds a testcase for PR fortran/33646. OK to install?


H.J.
----
2007-10-04  H.J. Lu  <hongjiu.lu@intel.com>

	PR fortran/33646
	* gfortran.dg/pr33646.f90: New file.

--- gcc/testsuite/gfortran.dg/pr33646.f90.pr33646	2007-10-04 06:51:58.000000000 -0700
+++ gcc/testsuite/gfortran.dg/pr33646.f90	2007-10-04 06:51:34.000000000 -0700
@@ -0,0 +1,59 @@
+! { dg-do compile }
+! PR fortran/33646
+!
+!
+
+module BAR_MODULE
+   implicit none
+   private
+   public    create_
+   interface create_
+      module procedure create
+   end interface
+   type system_type
+       integer(kind=kind(1)) :: max_memory_used
+   end type
+
+contains
+
+   subroutine create(self)
+    type(system_type) :: self
+      pointer :: self
+      allocate(self)
+   end subroutine
+
+end
+
+module FOO_MODULE
+   use BAR_MODULE
+   implicit none
+   private
+   public    create_
+   interface create_
+      module procedure create
+   end interface
+
+   public    create_copy_
+   interface create_copy_
+      module procedure create_copy
+   end interface
+contains
+
+   subroutine create(self)
+    character(*) :: self
+      pointer :: self
+      nullify(self)
+      allocate(self)
+
+      self = " "
+   end subroutine
+
+   subroutine create_copy(self,s)
+    character(*) :: self
+      pointer :: self
+      character(*) :: s
+      call create_(self)
+   end subroutine
+end
+
+! { dg-final { cleanup-modules "BAR_MODULE FOO_MODULE" } }

Re: PATCH: PR fortran/33646: [4.3 Regression] Gcc 4.3 revision 128954 failed tonto in SPEC CPU 2006

[François-Xavier Coudert]

> +! { dg-final { cleanup-modules "BAR_MODULE FOO_MODULE" } }

I'm not sure but I think that both modules names should be lowercase
in the cleanup-modules directive. You can check that, after running
the testsuite, the files bar_module.mod and foo_module.mod have
correctly been removed from the testsuite directory.

Other than that, it's OK.

FX

Re: PATCH: PR fortran/33646: [4.3 Regression] Gcc 4.3 revision 128954 failed tonto in SPEC CPU 2006

[Richard Guenther]

On 10/4/07, H.J. Lu <hjl@lucon.org> wrote:
> This patch adds a testcase for PR fortran/33646. OK to install?

Yes, testcases for fixed PRs are obvious.

Richard.

>
> H.J.
> ----
> 2007-10-04  H.J. Lu  <hongjiu.lu@intel.com>
>
>         PR fortran/33646
>         * gfortran.dg/pr33646.f90: New file.
>
> --- gcc/testsuite/gfortran.dg/pr33646.f90.pr33646       2007-10-04 06:51:58.000000000 -0700
> +++ gcc/testsuite/gfortran.dg/pr33646.f90       2007-10-04 06:51:34.000000000 -0700
> @@ -0,0 +1,59 @@
> +! { dg-do compile }
> +! PR fortran/33646
> +!
> +!
> +
> +module BAR_MODULE
> +   implicit none
> +   private
> +   public    create_
> +   interface create_
> +      module procedure create
> +   end interface
> +   type system_type
> +       integer(kind=kind(1)) :: max_memory_used
> +   end type
> +
> +contains
> +
> +   subroutine create(self)
> +    type(system_type) :: self
> +      pointer :: self
> +      allocate(self)
> +   end subroutine
> +
> +end
> +
> +module FOO_MODULE
> +   use BAR_MODULE
> +   implicit none
> +   private
> +   public    create_
> +   interface create_
> +      module procedure create
> +   end interface
> +
> +   public    create_copy_
> +   interface create_copy_
> +      module procedure create_copy
> +   end interface
> +contains
> +
> +   subroutine create(self)
> +    character(*) :: self
> +      pointer :: self
> +      nullify(self)
> +      allocate(self)
> +
> +      self = " "
> +   end subroutine
> +
> +   subroutine create_copy(self,s)
> +    character(*) :: self
> +      pointer :: self
> +      character(*) :: s
> +      call create_(self)
> +   end subroutine
> +end
> +
> +! { dg-final { cleanup-modules "BAR_MODULE FOO_MODULE" } }
>

Re: PATCH: PR fortran/33646: [4.3 Regression] Gcc 4.3 revision 128954 failed tonto in SPEC CPU 2006

[H.J. Lu]

On Thu, Oct 04, 2007 at 03:06:25PM +0100, François-Xavier Coudert wrote:
> > +! { dg-final { cleanup-modules "BAR_MODULE FOO_MODULE" } }
> 
> I'm not sure but I think that both modules names should be lowercase
> in the cleanup-modules directive. You can check that, after running
> the testsuite, the files bar_module.mod and foo_module.mod have
> correctly been removed from the testsuite directory.
> 
> Other than that, it's OK.

There are

# Remove files for specified Fortran modules.
proc cleanup-modules { modlist } { 
    foreach modname $modlist {
        remove-build-file [string tolower $modname].mod
    }   
}

I double checked that bar_module.mod and foo_module.mod were
removed. I am checking in my patch now.

Thanks.

H.J.

Re: PATCH: PR fortran/33646: [4.3 Regression] Gcc 4.3 revision 128954 failed tonto in SPEC CPU 2006

[François-Xavier Coudert]

> # Remove files for specified Fortran modules.
> proc cleanup-modules { modlist } {
>     foreach modname $modlist {
>         remove-build-file [string tolower $modname].mod
>     }
> }
>
> I double checked that bar_module.mod and foo_module.mod were
> removed. I am checking in my patch now.

Great, thanks.

FX