From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Jakub Jelinek" <jakub@redhat.com>
Cc: "Sebastian Pop" <spop@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix tree-data-ref.c ICE on VIEW_CONVERT_EXPR<type>(0) (PR tree-optimization/33856)
Date: Sat, 27 Oct 2007 19:16:00 -0000 [thread overview]
Message-ID: <84fc9c000710271053w384927cck11e50a3263f1c8cd@mail.gmail.com> (raw)
In-Reply-To: <20071027171552.GY5451@devserv.devel.redhat.com>
On 10/27/07, Jakub Jelinek <jakub@redhat.com> wrote:
> On Sat, Oct 27, 2007 at 06:33:55PM +0200, Richard Guenther wrote:
> > While there might be cases we (currently) do not fold
> > VIEW_CONVERT_EXPR<>(cst), did you look at why we do not in this
> > particular case (what's some_type?). Possibly a separate PR for
>
> Yes. some_type in this case is a RECORD_TYPE, and folding VIEW_CONVERT_EXPR
> (particularly in native_interpret_expr) handles only integral, floating
> and vector types. Not sure if it is a good idea to change that (or perhaps
> just special case 0 there and turn that into a zero element CONSTRUCTOR of
> the corresponding type). Or perhaps SRA could avoid creating
> VIEW_CONVERT_EXPR for RECORD_TYPE/UNION_TYPE.
>
> > not folding this case is appropriate so we can address this during next
> > stage1.
> >
> > Does this PR happen because key is uninitialized?
>
> Yes, that VIEW_CONVERT_EXPR is created during early SRA (and it a struct
> of two ints, so on LP64 it is the same size as long)
Interesting. Why does SRA bother to initialize uninitialized fields?
Richard.
next prev parent reply other threads:[~2007-10-27 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 16:39 Jakub Jelinek
2007-10-27 16:50 ` Richard Guenther
2007-10-27 18:08 ` Jakub Jelinek
2007-10-27 19:16 ` Richard Guenther [this message]
2007-10-27 21:34 ` Jakub Jelinek
2007-10-27 22:26 ` Andrew Pinski
2007-10-27 22:50 ` Richard Guenther
2007-10-28 20:28 ` Sebastian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fc9c000710271053w384927cck11e50a3263f1c8cd@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=spop@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).