public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Andrew Pinski" <pinskia@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix tree-opt/33589 out of SSA not cleaning up eh info for statements
Date: Sun, 28 Oct 2007 13:38:00 -0000	[thread overview]
Message-ID: <84fc9c000710280555p41098bc2sfa9a9104dfbb885b@mail.gmail.com> (raw)
In-Reply-To: <de8d50360710280540s173e63datf236893696932dd9@mail.gmail.com>

On 10/28/07, Andrew Pinski <pinskia@gmail.com> wrote:
> Hi,
>   The problem here is that out of SSA (via TER) replaces the function
> expression inside a CALL_EXPR with a nothrowing function.  So we go
> from a possible throwing call to a call which is known not to throw.
> But Out of SSA does not call maybe_clean_or_replace_eh_stmt to make
> sure the eh information is updated so we get an ICE.
>
> This fixes the problem by calling maybe_clean_or_replace_eh_stmt if
> the expression changed.  We may as well also call
> tree_purge_dead_eh_edges if maybe_clean_or_replace_eh_stmt returns
> true also to cleanup the dead edges now instead of during
> final_cleanup.
>
> OK? Bootstrapped and tested on i386-apple-darwin8.10.1.

Ok.

Thanks,
Richard.

> :ADDPATCH tree-opt:
>
> Thanks,
> Andrew Pinski
>
> ChangeLog:
> * tree-outof-ssa.c (rewrite_trees): If the statement changed, cleanup
> the eh information on the statement.
>
>
> * testsuite/g++.dg/torture/pr33589-1.C: New testcase.
> * testsuite/g++.dg/torture/pr33589-2.C: New testcase.
>
>

      parent reply	other threads:[~2007-10-28 12:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-28 12:57 Andrew Pinski
2007-10-28 13:14 ` Diego Novillo
2007-10-28 13:38 ` Richard Guenther [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84fc9c000710280555p41098bc2sfa9a9104dfbb885b@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).