From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-207721-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 23067 invoked by alias); 14 Nov 2007 13:10:47 -0000
Received: (qmail 23059 invoked by uid 22791); 14 Nov 2007 13:10:47 -0000
X-Spam-Check-By: sourceware.org
Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.180)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 Nov 2007 13:10:45 +0000
Received: by py-out-1112.google.com with SMTP id a29so3139226pyi         for <gcc-patches@gcc.gnu.org>; Wed, 14 Nov 2007 05:10:43 -0800 (PST)
Received: by 10.65.242.7 with SMTP id u7mr2442134qbr.1195045843059;         Wed, 14 Nov 2007 05:10:43 -0800 (PST)
Received: by 10.65.232.20 with HTTP; Wed, 14 Nov 2007 05:10:42 -0800 (PST)
Message-ID: <84fc9c000711140510x2af9822dmbf085c51f9907cfd@mail.gmail.com>
Date: Wed, 14 Nov 2007 14:22:00 -0000
From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Diego Novillo" <dnovillo@google.com>
Subject: Re: Fix PR 33870
Cc: gcc-patches@gcc.gnu.org, "Richard Guenther" <rguenther@suse.de>
In-Reply-To: <473AF069.7010101@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <b798aad50711071624q3c0ffdf0ib21f115b838a0736@mail.gmail.com> 	 <4739C673.5080905@google.com> 	 <84fc9c000711130808s5ecc11fcp1df00f20f379b76c@mail.gmail.com> 	 <84fc9c000711140255m22880809w7611ad878918bf96@mail.gmail.com> 	 <84fc9c000711140317o5abefc88n1c01e562d46baed0@mail.gmail.com> 	 <473AE434.3060404@google.com> 	 <84fc9c000711140435u2f885e90mca102b52b4860139@mail.gmail.com> 	 <473AECED.3010804@google.com> 	 <84fc9c000711140446l74fc9b36l4bfc2f024a21a66f@mail.gmail.com> 	 <473AF069.7010101@google.com>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-11/txt/msg00796.txt.bz2

On Nov 14, 2007 1:56 PM, Diego Novillo <dnovillo@google.com> wrote:
> Richard Guenther wrote:
>
> > I guess in add_uids_for_ptset instead of
> >
> > !                     if (SFT_NESTING_LEVEL (sft) > 0)
> > !                       SFT_UNPARTITIONABLE_P (sft) = true;
> >
> > we can get away with only doing that if the type of the SFT itself could
> > have subvariables (which is probably again what you intended?).
>
> Hmm, well the SFTs themselves are usually of scalar type.  The first SFT
> of an int[] array is of type int.  Yes, the bug is around here.  Perhaps
> the easiest way to fix this is to mark the variable earlier when we are
> pushing fields in the fieldstack (in the code that computes the nesting
> level).  And then transport that marker into the SFT here.

Yes, I'm doing that at the moment.  Stay tuned for a patch.

Richard.