From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-213402-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 16395 invoked by alias); 7 Mar 2008 15:40:11 -0000
Received: (qmail 16384 invoked by uid 22791); 7 Mar 2008 15:40:11 -0000
X-Spam-Check-By: sourceware.org
Received: from rn-out-0910.google.com (HELO rn-out-0910.google.com) (64.233.170.184)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Mar 2008 15:39:53 +0000
Received: by rn-out-0910.google.com with SMTP id s46so699769rnb.14         for <gcc-patches@gcc.gnu.org>; Fri, 07 Mar 2008 07:39:50 -0800 (PST)
Received: by 10.142.133.15 with SMTP id g15mr690064wfd.42.1204904389448;         Fri, 07 Mar 2008 07:39:49 -0800 (PST)
Received: by 10.142.86.17 with HTTP; Fri, 7 Mar 2008 07:39:49 -0800 (PST)
Message-ID: <84fc9c000803070739q797105ach9fcd81c9e4680f85@mail.gmail.com>
Date: Fri, 07 Mar 2008 15:40:00 -0000
From: "Richard Guenther" <richard.guenther@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: PATCH: PR tree-optimization/35494: [4.4 Regression]: Revision 132991 breaks 483.xalancbmk
Cc: gcc-patches@gcc.gnu.org
In-Reply-To: <20080307153004.GA10362@lucon.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080307150023.GA8336@lucon.org> 	 <84fc9c000803070719q31f33383hcba3e8798974033f@mail.gmail.com> 	 <20080307153004.GA10362@lucon.org>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2008-03/txt/msg00472.txt.bz2

On Fri, Mar 7, 2008 at 4:30 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Mar 07, 2008 at 04:19:01PM +0100, Richard Guenther wrote:
>  > On Fri, Mar 7, 2008 at 4:00 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>  > > We can't fold glocal variables with NULL DECL_INITIAL. I am testing it
>  > >  on Linux/x86 and Linux/Intel64 as well as 483.xalancbmk. OK to install
>  > >  if all pass?
>  >
>  > Hm, use targetm.binds_local_p instead?
>  >
>
>  I don't think targetm.binds_local_p is appropriate here.
>  targetm.binds_local_p tells me if a symbol is local to
>  the module, which may consist of many files, and a symbol
>  local to the module may be initialized to a different value
>  in another file.  But here we want to check if a symbol local
>  to the file.

The patch is ok then if testing passes.

Richard.