From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5629 invoked by alias); 9 Oct 2008 09:50:04 -0000 Received: (qmail 5616 invoked by uid 22791); 9 Oct 2008 09:50:03 -0000 X-Spam-Check-By: sourceware.org Received: from mu-out-0910.google.com (HELO mu-out-0910.google.com) (209.85.134.189) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Oct 2008 09:49:28 +0000 Received: by mu-out-0910.google.com with SMTP id i2so3791393mue.6 for ; Thu, 09 Oct 2008 02:49:25 -0700 (PDT) Received: by 10.187.241.11 with SMTP id t11mr1740874far.101.1223545764880; Thu, 09 Oct 2008 02:49:24 -0700 (PDT) Received: by 10.187.174.3 with HTTP; Thu, 9 Oct 2008 02:49:24 -0700 (PDT) Message-ID: <84fc9c000810090249tc2fecat4da2159a1740e261@mail.gmail.com> Date: Thu, 09 Oct 2008 13:09:00 -0000 From: "Richard Guenther" To: "=?BIG5?B?RG91ZyBLd2FuICjD9q62vHcp?=" Subject: Re: [LTO] free_language_specifics crashes C++ pretty-printer Cc: gcc-patches In-Reply-To: <498552560810090136l7cd7079fm9d32824101d379b9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <498552560810082335x7f15aeafo392402ee3c6f79d9@mail.gmail.com> <84fc9c000810090055p68b0fc51gbb3dc7c145c6bb24@mail.gmail.com> <498552560810090109q232f7b01h6a97a9a1877bb400@mail.gmail.com> <84fc9c000810090120j26f198ccs89b0b26ecfded89a@mail.gmail.com> <498552560810090124j6e47e909yed19015509ae56db@mail.gmail.com> <84fc9c000810090127q32c76148rcd2115649116a457@mail.gmail.com> <498552560810090136l7cd7079fm9d32824101d379b9@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-10/txt/msg00388.txt.bz2 On Thu, Oct 9, 2008 at 10:36 AM, Doug Kwan ($Bop?6y~(B) wrote: > 2008/10/9 Richard Guenther : > >> No, but I don't see how this matters here. announce_function >> is a debugging thing, and in the end we shouldn't emit new >> diagnostics from the link-time run of LTO. > > This happens before the link-time run of the LTO. In the C/C++ > frontends, we strip all language specifics before writing out the IR. > > I think we still want LTO to emit new diagnostics. If a user tried to > combine objects with inconsistent function declarations, LTO should > detect this and emit an error message. Note that this situation > cannot be detected when individual source files are compiled prior to > LTO. Ok. Still as this is a debugging/diagnostic function only, maybe the simplest thing is to just not use the langhook but use DECL_NAME always. Or DECL_ASSEMBLER_NAME, as this is more specific in the C++ case? Richard. > -Doug >