From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-229933-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 6280 invoked by alias); 5 Nov 2008 09:21:33 -0000
Received: (qmail 6230 invoked by uid 22791); 5 Nov 2008 09:21:32 -0000
X-Spam-Check-By: sourceware.org
Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.153)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Nov 2008 09:20:53 +0000
Received: by fg-out-1718.google.com with SMTP id e21so3233353fga.28         for <gcc-patches@gcc.gnu.org>; Wed, 05 Nov 2008 01:20:50 -0800 (PST)
Received: by 10.187.228.6 with SMTP id f6mr102067far.52.1225876850250;         Wed, 05 Nov 2008 01:20:50 -0800 (PST)
Received: by 10.187.174.3 with HTTP; Wed, 5 Nov 2008 01:20:50 -0800 (PST)
Message-ID: <84fc9c000811050120u27692d32ra32c27d1eefc2cdf@mail.gmail.com>
Date: Wed, 05 Nov 2008 09:21:00 -0000
From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Ralph Loader" <suckfish@ihug.co.nz>
Subject: Re: [PATCH] Fix for PR 37809 and 37807
Cc: gcc-patches@gcc.gnu.org
In-Reply-To: <20081105205605.20d170c4@i.geek.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081022181234.2acf7548@i.geek.nz> 	 <84fc9c000810220316t20257102t9ce3b53e95d3400b@mail.gmail.com> 	 <20081105205605.20d170c4@i.geek.nz>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2008-11/txt/msg00148.txt.bz2

On Wed, Nov 5, 2008 at 8:56 AM, Ralph Loader <suckfish@ihug.co.nz> wrote:
> [Sorry for the delay on following up on this]
>
>> The rtlanal.c parts are ok.  I wonder if we ever hit the _or_truncate
>> case with vector modes in force_to_mode though - can you check if
>> using gen_lowpart instead of gen_lowpart_or_truncate works?
>
> I checked this and gen_lowpart instead of gen_lowpart_or_truncate
> appears fine.
>
> Attached is patch modified to use gen_lowpart, and with the test case
> cleaned up & changeloged.

The patch is ok this way.

Thanks,
Richard.

> Cheers,
> Ralph.
>
>
>>
>> Btw, you missa ChangeLog entry for the testcase for
>> testsuite/ChangeLog.
>>
>> Thanks,
>> Richard.
>>
>> > 2008-10-19  Ralph Loader  <suckfish@ihug.co.nz>
>> >
>> >        PR middle-end/37807, middle-end/37809
>> >        * combine.c (force_to_mode): Do not process vector types.
>> >
>> >        * rtlanal.c (nonzero_bits1): Do not process vector types.
>> >        (num_sign_bit_copies1): Likewise.
>> >
>> > Cheers,
>> > Ralph.
>> >
>