public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Richard Guenther" <richard.guenther@gmail.com>
To: "Uros Bizjak" <ubizjak@gmail.com>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, middle-end]: Fix PR 37286, ICE subst_stack_regs_pat, at reg-stack.c:1537
Date: Wed, 05 Nov 2008 09:24:00 -0000	[thread overview]
Message-ID: <84fc9c000811050123s7803655fnd647db0eea36321c@mail.gmail.com> (raw)
In-Reply-To: <5787cf470811030708u3bede55ew2267b7d6358854e5@mail.gmail.com>

On Mon, Nov 3, 2008 at 4:08 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
> This is another example of uninitialized variable confusing regstack.
> Instead of ICEing on uninitialized stack slot, initialize variable
> with a NaN. This way, we will generate FP exception if program flow
> reaches the instruction (if exceptions are enabled), but we will be
> able to compile the source.
>
> BTW: Compiling original fortran testcase from the PR with -Wall, we indeed get:
>
> pr37286.f90: In function 'gn_monte_rand':
> pr37286.f90:31: warning: 'monte_temp' may be used uninitialized in this function
>
> 2008-11-03  Uros Bizjak  <ubizjak@gmail.com>
>
>        PR middle-end/37286
>        * reg-stack.c (subst_stack_regs_pat) [MINUS, DIV, MULT, PLUS]:
>        Initialize uninitialized input registers with a NaN.
>
> testsuite/ChangeLog:
>
> 2008-11-03  Uros Bizjak  <ubizjak@gmail.com>
>
>        PR middle-end/37286
>        * gfortran.dg/pr37286.f90: New test.
>
> The patch was bootstrapped and regression tested on i686-pc-linux-gnu.
> OK for mainline?

Ok.

Thanks,
Richard.

> Uros.
>

      reply	other threads:[~2008-11-05  9:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-03 15:09 Uros Bizjak
2008-11-05  9:24 ` Richard Guenther [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84fc9c000811050123s7803655fnd647db0eea36321c@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).