From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15386 invoked by alias); 26 Apr 2009 20:27:05 -0000 Received: (qmail 15371 invoked by uid 22791); 26 Apr 2009 20:27:03 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_62,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-bw0-f224.google.com (HELO mail-bw0-f224.google.com) (209.85.218.224) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 26 Apr 2009 20:26:58 +0000 Received: by bwz24 with SMTP id 24so1877349bwz.8 for ; Sun, 26 Apr 2009 13:26:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.116.69 with SMTP id l5mr4540357bkq.52.1240777615300; Sun, 26 Apr 2009 13:26:55 -0700 (PDT) In-Reply-To: References: <49EE0F0C.1090101@redhat.com> <84fc9c000904240721he410b55p9776a1d033f82fc3@mail.gmail.com> <84fc9c000904240732i6743b0cas423a2ea9bc33387e@mail.gmail.com> Date: Sun, 26 Apr 2009 20:34:00 -0000 Message-ID: <84fc9c000904261326u6144c914gb25891f877ab77db@mail.gmail.com> Subject: Re: [RFA] expand from SSA form (1/2) From: Richard Guenther To: Michael Matz Cc: gcc-patches@gcc.gnu.org, Andrew MacLeod , Andrey Belevantsev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-04/txt/msg02055.txt.bz2 On Sun, Apr 26, 2009 at 10:19 PM, Michael Matz wrote: > Hi, > > On Fri, 24 Apr 2009, Richard Guenther wrote: > >> *************** struct var_ann_d GTY(()) >> *** 234,243 **** >> =A0 =A0/* Used by var_map for the base index of ssa base variables. =A0*/ >> =A0 =A0unsigned base_index; >> >> hmm, so what is needed to remove base_index as well? > > Rewriting var_map_base_init() to not use var annotations. =A0SSA name > coalescing and conflict building wants to have a DECL->dense-integer > mapping for various reasons (two-stage approach for building > conflicts). > > Currently that mapping is generated by storing the next available index > into the var annotation (to be able to read it out again when the same > basevar is seen for a different partition). =A0But this whole info is > strictly local to the above function, so it doesn't need to live in the > annotation. =A0I could very well implement this as an array indexed by > DECL_UID. =A0The UIDs shouldn't become exceptionally large, so that seems Hm. DECL_UIDs are sparse (and global), it would be a bad idea to index an array with it. Is var_ann->common.aux already used by out-of-SSA? (also common.rn and common.value_handle are "local" values, but they should go as well in the end). > feasible. =A0I wouldn't want to use a hash-table for fear of slowing down > var_map_base_init(). I think it would be not too bad ;) Richard.