From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27343 invoked by alias); 3 Sep 2009 10:52:32 -0000 Received: (qmail 27334 invoked by uid 22791); 3 Sep 2009 10:52:32 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-vw0-f174.google.com (HELO mail-vw0-f174.google.com) (209.85.212.174) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Sep 2009 10:52:27 +0000 Received: by vws4 with SMTP id 4so1414787vws.0 for ; Thu, 03 Sep 2009 03:52:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.108.42 with SMTP id d42mr12702262vcp.88.1251975141966; Thu, 03 Sep 2009 03:52:21 -0700 (PDT) In-Reply-To: <4A9EEF09.8060509@redhat.com> References: <90baa01f0908311113h325a0102pf8ed4cea3bb23381@mail.gmail.com> <206fcf960909021203na444027xd9f6efc3522a1879@mail.gmail.com> <90baa01f0909021250y47d31cecv5fd2b5dd98a995db@mail.gmail.com> <206fcf960909021418m7d08432cidbbd80f2f38cfc9a@mail.gmail.com> <90baa01f0909021421n7751905dt399ae6be23077fc2@mail.gmail.com> <4A9EEF09.8060509@redhat.com> Date: Thu, 03 Sep 2009 10:52:00 -0000 Message-ID: <84fc9c000909030352i7d870d58od9ad8b3870916748@mail.gmail.com> Subject: Re: [PATCH]: Cast in c-pretty-print.c causes warning From: Richard Guenther To: Richard Henderson Cc: Kai Tietz , Gabriel Dos Reis , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-09/txt/msg00230.txt.bz2 On Thu, Sep 3, 2009 at 12:17 AM, Richard Henderson wrote: > On 09/02/2009 02:21 PM, Kai Tietz wrote: >> >> Ok, I can file a patch to add gstdint.h to system.h, or is it better >> to use here just a config.h check for existing stdint.h and otherwise >> fall back to long type for intptr_t? > > It's best to have a configure check. > See the standard autoconf macro AC_TYPE_UINTPTR_T. The LTO branch also makes use of uintptr_t and adds AC_CHECK_TYPE(intptr_t, long) which is obviously wrong for LLP64 hosts ;) But see config/stdint.m4 and config/stdint_h.m4. Richard. > > r~ >