From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7106 invoked by alias); 8 Nov 2009 10:10:44 -0000 Received: (qmail 7097 invoked by uid 22791); 8 Nov 2009 10:10:43 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f176.google.com (HELO mail-px0-f176.google.com) (209.85.216.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 08 Nov 2009 10:10:40 +0000 Received: by pxi6 with SMTP id 6so925946pxi.0 for ; Sun, 08 Nov 2009 02:10:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.170.5 with SMTP id s5mr340857rve.6.1257675038518; Sun, 08 Nov 2009 02:10:38 -0800 (PST) In-Reply-To: <200911081057.30326.ebotcazou@adacore.com> References: <84fc9c000911080140o1593d081r7ec627b08afe0cd6@mail.gmail.com> <200911081057.30326.ebotcazou@adacore.com> Date: Sun, 08 Nov 2009 10:17:00 -0000 Message-ID: <84fc9c000911080210v55918633xad44555593b5eb4d@mail.gmail.com> Subject: Re: fix -fcompare-debug regression in free_lang_data From: Richard Guenther To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Alexandre Oliva Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg00427.txt.bz2 On Sun, Nov 8, 2009 at 10:57 AM, Eric Botcazou wrot= e: >> Hm, no idea why it was there in the first place. =A0A patch to remove it >> is pre-approved (if that passes bootstrap & regtest of course). > > Because of the FIXME: > > =A0/* FIXME. =A0Remove after save_debug_info is working. =A0*/ > =A0if (!(flag_generate_lto > =A0 =A0 =A0 =A0|| (!in_lto_p > =A0 =A0 =A0 =A0 =A0 =A0&& !flag_gtoggle && debug_info_level <=3D DINFO_LE= VEL_TERSE))) > =A0 =A0return 0; > > If you remove the flag_gtoggle test, you will end up generating different= code > with -gtoggle -g0 and -gtoggle -g for the languages whose boolean_type_no= de > is changed, thus breaking bootstrap comparison. > > Of course, as Alexandre said, that would probably be a good thing because > different code is already generated for these languages at -g and -g0 due= to > the boolean_type_node hack, but it's hidden by -gtoggle. Well, sure. But that's clearly a bug (no, not the boolean_type_node featur= e, but the different code generation). Richard. > -- > Eric Botcazou >