From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30728 invoked by alias); 19 Nov 2009 10:56:20 -0000 Received: (qmail 30720 invoked by uid 22791); 19 Nov 2009 10:56:20 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS,SUBJECT_FUZZY_VPILL X-Spam-Check-By: sourceware.org Received: from mail-pz0-f203.google.com (HELO mail-pz0-f203.google.com) (209.85.222.203) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Nov 2009 10:55:25 +0000 Received: by pzk41 with SMTP id 41so1418867pzk.0 for ; Thu, 19 Nov 2009 02:55:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.132.13 with SMTP id f13mr745722rvd.124.1258628122391; Thu, 19 Nov 2009 02:55:22 -0800 (PST) In-Reply-To: References: <84fc9c000911080156iff6d687o26db10af3e9fba5d@mail.gmail.com> <84fc9c000911170739v76a2e911vc6794e597c8d134e@mail.gmail.com> Date: Thu, 19 Nov 2009 10:59:00 -0000 Message-ID: <84fc9c000911190255q12e2a1c8nc0af0587883d7455@mail.gmail.com> Subject: Re: [vta, graphite?] propagate degenerate phi nodes into debug stmts From: Richard Guenther To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg01001.txt.bz2 On Thu, Nov 19, 2009 at 5:27 AM, Alexandre Oliva wrote: > On Nov 17, 2009, Richard Guenther wrote: > >> Well, just adjust degenerate_phi_result to do instead of calling >> operand_equal_p > >> =A0 else if (TREE_CODE (arg) !=3D TREE_CODE (val) >> =A0 =A0 =A0 =A0 =A0 =A0 =A0|| (TREE_CODE (arg) =3D=3D SSA_NAME >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&& arg !=3D val) >> =A0 =A0 =A0 =A0 =A0 =A0 =A0|| !operand_equal_p (arg, val, 0)) >> =A0 =A0 break; > >> that should fix it. > > Good idea. =A0This wouldn't avoid calling operand_equal_p with two > different SSA_NAMEs, one of which may have already been released, but it > wasn't too hard to arrange for it not to do so. > > Tweaking operand_equal_p() itself could have been a nicer change, but I > couldn't figure out how to do it properly. =A0We test types before > stripping NOPs that could have yielded the same SSA names. =A0I wouldn't > like to slow things down testing for NULL types or special-casing > SSA_NAMEs too much. > > Here's what I'm testing now. Ok if it passes testing. Thanks, Richard. > > > -- > Alexandre Oliva, freedom fighter =A0 =A0http://FSFLA.org/~lxoliva/ > You must be the change you wish to see in the world. -- Gandhi > Be Free! -- http://FSFLA.org/ =A0 FSF Latin America board member > Free Software Evangelist =A0 =A0 =A0Red Hat Brazil Compiler Engineer > >