From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-253743-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 311 invoked by alias); 1 Dec 2009 14:39:13 -0000
Received: (qmail 302 invoked by uid 22791); 1 Dec 2009 14:39:12 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f203.google.com (HELO mail-pz0-f203.google.com) (209.85.222.203)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Dec 2009 14:39:03 +0000
Received: by pzk41 with SMTP id 41so3431327pzk.0         for <gcc-patches@gcc.gnu.org>; Tue, 01 Dec 2009 06:39:01 -0800 (PST)
MIME-Version: 1.0
Received: by 10.141.41.11 with SMTP id t11mr396718rvj.51.1259678341193; Tue,  	01 Dec 2009 06:39:01 -0800 (PST)
In-Reply-To: <20091201092954.bmda2ognms88488g-nzlynne@webmail.spamcop.net>
References: <20091130133452.hgxpnrkgu8cw0gk8-nzlynne@webmail.spamcop.net> 	 <4B1418E2.9050400@starynkevitch.net> 	 <20091130143921.vi6qzwej48so8o8c-nzlynne@webmail.spamcop.net> 	 <4B1421D0.40004@starynkevitch.net> 	 <20091201005430.4w42zvtxcwk4g0s4-nzlynne@webmail.spamcop.net> 	 <84fc9c000912010219n2dcf0103x635aeca1cbfbbf34@mail.gmail.com> 	 <20091201092954.bmda2ognms88488g-nzlynne@webmail.spamcop.net>
Date: Tue, 01 Dec 2009 14:52:00 -0000
Message-ID: <84fc9c000912010639k7e08df0el2e8eb2a4092efe2c@mail.gmail.com>
Subject: Re: Fwd: RFA: plugin events for ICI
From: Richard Guenther <richard.guenther@gmail.com>
To: Joern Rennecke <amylaar@spamcop.net>
Cc: Basile STARYNKEVITCH <basile@starynkevitch.net>, ctuning-discussions@googlegroups.com,  	gcc-patches <gcc-patches@gcc.gnu.org>, Grigori Fursin <grigori.fursin@inria.fr>,  	Grigori Fursin <gfursin@gmail.com>, Zbigniew Chamski <zbigniew.chamski@gmail.com>,  	Ian Lance Taylor <iant@google.com>, Albert Cohen <Albert.Cohen@inria.fr>,  	Yuri Kashnikoff <yuri.kashnikoff@gmail.com>, Yuanjie Huang <huangyuanjie@ict.ac.cn>,  	Liang Peng <pengliang@ict.ac.cn>, dorit@il.ibm.com,  	Mircea Namolaru <NAMOLARU@il.ibm.com>, Diego Novillo <dnovillo@google.com>,  	Paolo Bonzini <bonzini@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2009-12/txt/msg00060.txt.bz2

On Tue, Dec 1, 2009 at 3:29 PM, Joern Rennecke <amylaar@spamcop.net> wrote:
> Quoting Richard Guenther <richard.guenther@gmail.com>:
>>
>> The rest looks reasonable, so if you can re-submit without the
>> above changes...?
>
> Please find attached the reduced patch that I am currently testing.

@@ -1092,7 +1096,8 @@ static GTY ((length ("nnodes"))) struct
    function CALLBACK for every function in the call graph.  Otherwise,
    call CALLBACK on the current function.  */

-static void
+/* This function is global so that plugins can use it.  */

please merge this comments with the overall function comments.

+int
+unregister_callback (const char *plugin_name, int event)

this function needs a comment.

The middle-end changes are ok with the above changes.  Please
get approval from plugin maintainers for the changes therein
and from a build-system maintainer for the gcc/Makefile.in
change.

Thanks,
Richard.