From: Richard Guenther <richard.guenther@gmail.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: PING: PATCH to expand_used_vars for debug/42800 (P1 regression)
Date: Tue, 23 Feb 2010 10:44:00 -0000 [thread overview]
Message-ID: <84fc9c001002230228r648e505cpefddc180e51aa5cf@mail.gmail.com> (raw)
In-Reply-To: <4B8301BC.4090308@redhat.com>
On Mon, Feb 22, 2010 at 11:14 PM, Jason Merrill <jason@redhat.com> wrote:
> On 02/19/2010 05:18 PM, Jason Merrill wrote:
>>
>> The problem is this PR is that when are writing out the debug info for
>> the temporary containing the upper bound of the VLA, its rtl still
>> refers to virtual regs, so dwarf2out gives up and doesn't emit any debug
>> info for the upper bound. This happens because the Expand from SSA patch
>> broke Jakub's patch for PR 34037, such that expand_used_vars is no
>> longer re-adding the variable to cfun->local_decls.
>>
>> The patch adjusts the logic in expand_used_vars so that the PR 34037 fix
>> is executed again for this variable.
>>
>> Tested x86_64-pc-linux-gnu. OK for trunk?
Ok.
Thanks,
Richard.
prev parent reply other threads:[~2010-02-23 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 22:19 RFA: PATCH to expand_used_vars for debug/42800 Jason Merrill
2010-02-19 22:34 ` Jakub Jelinek
2010-02-22 22:26 ` PING: PATCH to expand_used_vars for debug/42800 (P1 regression) Jason Merrill
2010-02-23 10:44 ` Richard Guenther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fc9c001002230228r648e505cpefddc180e51aa5cf@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).