From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id CA9D13886C5E for ; Fri, 23 Jul 2021 06:53:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA9D13886C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 112B91FF55; Fri, 23 Jul 2021 06:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1627023204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRS0/6mZfPX93hdhOLoDir2SP/dgen33MdAxT56cKeU=; b=g9sLq0fyCVZ+bQkRvOtZlmvPKAolUcM+bJjP+jmNmXGhr/1qEm7oKojvNkCi54h7pi2P+0 1ippvCTvuscRJknaxxGkVncYC8gln8v58IhbX9HZcKJDcBeNCkBH8EB6/5rvqvZXVfbFD/ GtKHAWfh54Mz3+NIJgebqwu/WHKzHDI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1627023204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRS0/6mZfPX93hdhOLoDir2SP/dgen33MdAxT56cKeU=; b=8/npBqRsMzM8+nNfTkwAyGVRfXgvB98SkcU5JyBmlzwTEK4FrIH1Gu/zlblNkPslokgynq 38sFXBg9Qf6Xs1AA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id F3CDE136DD; Fri, 23 Jul 2021 06:53:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id xAu2OmNn+mDxNgAAGKfGzw (envelope-from ); Fri, 23 Jul 2021 06:53:23 +0000 Subject: Re: [PATCH v2] gcov: Add __gcov_info_to_gdca() To: Sebastian Huber , gcc-patches@gcc.gnu.org References: <20210713201553.108947-1-sebastian.huber@embedded-brains.de> <41f75927-6ff1-9cb8-0cd9-7aa091457956@embedded-brains.de> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <85497da5-4a19-df41-ce0b-09dbde4592ab@suse.cz> Date: Fri, 23 Jul 2021 08:53:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <41f75927-6ff1-9cb8-0cd9-7aa091457956@embedded-brains.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2021 06:53:25 -0000 On 7/23/21 8:21 AM, Sebastian Huber wrote: > On 23/07/2021 07:31, Martin Liška wrote: >>> +static void * >>> +allocate_handler (unsigned size, void *unused) >>> +{ >>> +  (void)unused; >>> +  return xmalloc (size); >>> +} >>> +#endif /* NEED_L_GCOV */ >>> + >>> +#if defined(NEED_L_GCOV) || defined(NEED_L_GCOV_INFO_TO_GCDA) >>> +static inline void >> >> Likewise here. >> >>> +dump_unsigned (gcov_unsigned_t word, >>> +           void (*dump) (const void *, unsigned, void *), >>> +           void *arg) >>> +{ >>> +  (*dump) (&word, sizeof (word), arg); >>> +} >> >> Likewise here. > > Adding the gcov_ prefix would make some lines longer than 79 characters. We already have several functions in this file without a gocv_ prefix, for example write_one_data(), write_topn_counters(). > All right, I don't insist on that. Cheers, Martin