From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 759903858CD1 for ; Tue, 9 Apr 2024 03:20:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 759903858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 759903858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712632814; cv=none; b=q/VFtO20BYM0fmDwZDOHxn80VCkUJUQoCjoU2Y1IIZ23gx1O+x9xuijEpa/L+0YzA5cPmA1/BsmlGU3TOSZ3B3D4qs5I20/y3FuKHho7ZphELdnYYh5St2nkh/J85KDbnMAp5oRemRDE83wRk8uvbYMIenIYM97k52b/kg1F26k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712632814; c=relaxed/simple; bh=Rx2XLiQJE/bJrXa0XGGkmg9AAok1aJiRhyPYt1ZbY2E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qBRANEv2JYHMZiI8juN7SIgbTzxmUEpIyqzyJr++05F7Sb3tjNMUrNr9xVCwF0azmw0RaO6n3uIgOthYshPSK8dTNiE7N2L4sWfvfu6oD3a6+L4nrJgA+ssDduhwIZyrmO+1kn3+O0RcbgzIKXpi8P7NOswAy2k6TCUwTODWJK4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4393E129009852; Tue, 9 Apr 2024 03:20:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=bxA4KuCTkyrJ7qWpcxx+XWFynJixPY1pIBnpHDhOErM=; b=eVUns+asXymLck8zF2Ej9UKzHh3F/jphcP1iF/r1e91GIZyEQJZc/CmAl5tGmTobzR7B fCTwknf7DyjgfHnvJsCvvf3VBsuLlT601VfS8zCEcBHph3HzER9/PnD1mcvcbQIOaShz kI61O0x7Cd5CCiXFVj2BXAzg3bequ9q8Zwo7OxfB8xfEGUAJGxwnzgbkmDvpBxe6Xs4T UsPReEWjIzV3osItjVlOGkEM4vgSagzCRQlcQHKGgC+Qll1fjICXz3DQs9lQDE0LHsKW 4d8puyJY9kEyujKRIEU27XOWkRBZcrICWyW4JX605QGutz8ucRUqQXxGby3JxlFk+06e 3Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcwjf007s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 03:20:11 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4393KAIe019883; Tue, 9 Apr 2024 03:20:10 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcwjf007p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 03:20:10 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43911C1f019109; Tue, 9 Apr 2024 03:20:09 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xbh4040qu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 03:20:09 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4393K6I340239530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Apr 2024 03:20:08 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F12B45805C; Tue, 9 Apr 2024 03:20:05 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C0A25805A; Tue, 9 Apr 2024 03:20:05 +0000 (GMT) Received: from [9.61.87.235] (unknown [9.61.87.235]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 9 Apr 2024 03:20:05 +0000 (GMT) Message-ID: <854a2232-adfa-4c5d-884a-fcb0a98b3051@linux.ibm.com> Date: Mon, 8 Apr 2024 22:20:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rs6000: Replace OPTION_MASK_DIRECT_MOVE with OPTION_MASK_P8_VECTOR [PR101865] To: "Kewen.Lin" Cc: Segher Boessenkool , David Edelsohn , GCC Patches References: <20234c37-d03b-a163-9e60-d63b965a55e0@linux.ibm.com> Content-Language: en-US From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: -5FTCe5mza_HED6YQxkWkrEvYxGTitoP X-Proofpoint-ORIG-GUID: NhnMYyzcRkLWPWFPF33SbzCa9fh8ALi2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-08_19,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=911 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404090019 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/8/24 9:37 PM, Kewen.Lin wrote: > on 2024/4/8 21:21, Peter Bergner wrote: > I prefer to remove it completely, that is: > >> -mdirect-move >> -Target Undocumented Mask(DIRECT_MOVE) Var(rs6000_isa_flags) WarnRemoved > > The reason why you still kept it is to keep a historical record here? I believe we've never completely removed an option before. I think the thought was, if some software package explicitly used the option, then they shouldn't see an 'unrecognized command-line option' error, but rather either a warning that the option was removed or just silently ignore it. Ie, we don't want to make a package that used to build with an old compiler now break its build because the option doesn't exist anymore. > Segher pointed out to me that this kind of option complete removal should be > stage 1 stuff, so let's defer to make it in a separated patch next release > (including some other options like mfpgpr you showed below etc.). :) If we're going to completely remove it, then for sure, it's a stage1 thing. I'd like to hear Segher's thoughts on whether we should completely remove it or just silently ignore it. > For the original patch, > >> +mno-direct-move >> +Target Undocumented WarnRemoved > > s/WarnRemoved/Ignore/ to match some other existing practice, there is no > warning now if specifying -mno-direct-move and it would be good to keep > the same behavior for users. If we want to silently ignore -mdirect-move and -mno-direct-move, then we just need to do: mdirect-move -Target Undocumented Mask(DIRECT_MOVE) Var(rs6000_isa_flags) WarnRemoved +Target Undocumented Ignore There's no need to mention -mno-direct-move at all then. It was only in the case I thought we wanted to warn against it's use that I added -mno-direct-move. >> That said, it's not what we've done with >> other options, but maybe those just need to be changed too? > > Yes, I think they need to be changed too (next release). If that's the consensus with Segher, sure, we can plan on that in stage1. Peter