public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kwok Cheung Yeung <kcy@codesourcery.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	Thomas Schwinge <thomas@codesourcery.com>,
	Tobias Burnus <tobias@codesourcery.com>
Subject: [PATCH] [OG10] Xfail libgomp.oacc-fortran/privatized-ref-2.f90 when offloading to nvptx
Date: Wed, 16 Sep 2020 18:34:37 +0100	[thread overview]
Message-ID: <85518091-66ad-4844-cd0f-b8a245d5af7b@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

Hello

I have committed this patch to xfail libgomp.oacc-fortran/privatized-ref-2.f90 
when the offload target is nvptx, as the generated code has some alloca calls 
which are currently not supported by nvptx (PR65181).

Kwok


[-- Attachment #2: alloca_xfail.patch --]
[-- Type: text/plain, Size: 1459 bytes --]

commit 1245f6f615fa08d2ab4165598c9db72c4dad4467
Author: Kwok Cheung Yeung <kcy@codesourcery.com>
Date:   Wed Sep 16 10:19:35 2020 -0700

    XFAIL libgomp.oacc-fortran/privatized-ref-2.f90 on nvptx
    
    The testcase uses alloca, which is not currently supported on nvptx
    (see PR65181).
    
    2020-09-16  Kwok Cheung Yeung  <kcy@codesourcery.com>
    
    	libgomp/
    	* testsuite/libgomp.oacc-fortran/privatized-ref-2.f90: XFAIL on nvptx.

diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index 6e313aa..890a4e2 100644
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -1,5 +1,9 @@
 2020-09-16  Kwok Cheung Yeung  <kcy@codesourcery.com>
 
+	* testsuite/libgomp.oacc-fortran/privatized-ref-2.f90: XFAIL on nvptx.
+
+2020-09-16  Kwok Cheung Yeung  <kcy@codesourcery.com>
+
 	* testsuite/libgomp.oacc-c++/privatized-ref-2.C (workers, vectors):
 	Reduce number of workers to 16.
 	* testsuite/libgomp.oacc-c++/privatized-ref-3.C (workers, vectors):
diff --git a/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-2.f90 b/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-2.f90
index ca8fbe8..658ab9e 100644
--- a/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-2.f90
+++ b/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-2.f90
@@ -1,4 +1,5 @@
 ! { dg-do run }
+! { dg-xfail-if "no alloca support" { offload_target_nvptx } }
 
 program main
   implicit none (type, external)

             reply	other threads:[~2020-09-16 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fc0dfbcc-0f5a-e63d-3943-80fb7b7cf03e@mentor.com>
2020-09-16 17:34 ` Kwok Cheung Yeung [this message]
     [not found]   ` <0968ff25a4dc4d9895682ce0669345c5@svr-orw-mbx-02.mgc.mentorg.com>
2021-05-21 14:28     ` Add 'libgomp.oacc-fortran/privatized-ref-2.f90' Thomas Schwinge
2022-02-22 16:39       ` Fix OpenACC gang-redundant execution in 'libgomp.oacc-fortran/privatized-ref-2.f90' (was: Add 'libgomp.oacc-fortran/privatized-ref-2.f90') Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85518091-66ad-4844-cd0f-b8a245d5af7b@codesourcery.com \
    --to=kcy@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=thomas@codesourcery.com \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).